Skip to content

Commit b884ade

Browse files
authored
fix: added missing request params in to the queryKeyFn (#169)
1 parent 2385221 commit b884ade

File tree

4 files changed

+25
-11
lines changed

4 files changed

+25
-11
lines changed

src/common.mts

+5-1
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,13 @@ export function createQueryKeyFnExport(
237237
queryKey: string,
238238
method: VariableDeclaration,
239239
type: "query" | "mutation" = "query",
240+
modelNames: string[] = [],
240241
) {
241242
// Mutation keys don't require clientOptions
242-
const params = type === "query" ? getRequestParamFromMethod(method) : null;
243+
const params =
244+
type === "query"
245+
? getRequestParamFromMethod(method, undefined, modelNames)
246+
: null;
243247

244248
// override key is used to allow the user to override the the queryKey values
245249
const overrideKey = ts.factory.createParameterDeclaration(

src/createUseQuery.mts

+6-1
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,12 @@ export const createUseQuery = ({
533533
queryKey,
534534
});
535535

536-
const queryKeyFn = createQueryKeyFnExport(queryKey, method);
536+
const queryKeyFn = createQueryKeyFnExport(
537+
queryKey,
538+
method,
539+
"query",
540+
modelNames,
541+
);
537542

538543
return {
539544
apiResponse: defaultApiResponse,

tests/__snapshots__/createSource.test.ts.snap

+6-6
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,19 @@ import { AxiosError } from "axios";
1919
export type FindPetsDefaultResponse = Awaited<ReturnType<typeof findPets>>["data"];
2020
export type FindPetsQueryResult<TData = FindPetsDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
2121
export const useFindPetsKey = "FindPets";
22-
export const UseFindPetsKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useFindPetsKey, ...(queryKey ?? [clientOptions])];
22+
export const UseFindPetsKeyFn = (clientOptions: Options<FindPetsData, true> = {}, queryKey?: Array<unknown>) => [useFindPetsKey, ...(queryKey ?? [clientOptions])];
2323
export type GetNotDefinedDefaultResponse = Awaited<ReturnType<typeof getNotDefined>>["data"];
2424
export type GetNotDefinedQueryResult<TData = GetNotDefinedDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
2525
export const useGetNotDefinedKey = "GetNotDefined";
2626
export const UseGetNotDefinedKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useGetNotDefinedKey, ...(queryKey ?? [clientOptions])];
2727
export type FindPetByIdDefaultResponse = Awaited<ReturnType<typeof findPetById>>["data"];
2828
export type FindPetByIdQueryResult<TData = FindPetByIdDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
2929
export const useFindPetByIdKey = "FindPetById";
30-
export const UseFindPetByIdKeyFn = (clientOptions: Options<unknown, true>, queryKey?: Array<unknown>) => [useFindPetByIdKey, ...(queryKey ?? [clientOptions])];
30+
export const UseFindPetByIdKeyFn = (clientOptions: Options<FindPetByIdData, true>, queryKey?: Array<unknown>) => [useFindPetByIdKey, ...(queryKey ?? [clientOptions])];
3131
export type FindPaginatedPetsDefaultResponse = Awaited<ReturnType<typeof findPaginatedPets>>["data"];
3232
export type FindPaginatedPetsQueryResult<TData = FindPaginatedPetsDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
3333
export const useFindPaginatedPetsKey = "FindPaginatedPets";
34-
export const UseFindPaginatedPetsKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useFindPaginatedPetsKey, ...(queryKey ?? [clientOptions])];
34+
export const UseFindPaginatedPetsKeyFn = (clientOptions: Options<FindPaginatedPetsData, true> = {}, queryKey?: Array<unknown>) => [useFindPaginatedPetsKey, ...(queryKey ?? [clientOptions])];
3535
export type AddPetMutationResult = Awaited<ReturnType<typeof addPet>>;
3636
export const useAddPetKey = "AddPet";
3737
export const UseAddPetKeyFn = (mutationKey?: Array<unknown>) => [useAddPetKey, ...(mutationKey ?? [])];
@@ -113,19 +113,19 @@ import { Pet, NewPet, Error, FindPetsData, FindPetsResponse, FindPetsError, AddP
113113
export type FindPetsDefaultResponse = Awaited<ReturnType<typeof findPets>>["data"];
114114
export type FindPetsQueryResult<TData = FindPetsDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
115115
export const useFindPetsKey = "FindPets";
116-
export const UseFindPetsKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useFindPetsKey, ...(queryKey ?? [clientOptions])];
116+
export const UseFindPetsKeyFn = (clientOptions: Options<FindPetsData, true> = {}, queryKey?: Array<unknown>) => [useFindPetsKey, ...(queryKey ?? [clientOptions])];
117117
export type GetNotDefinedDefaultResponse = Awaited<ReturnType<typeof getNotDefined>>["data"];
118118
export type GetNotDefinedQueryResult<TData = GetNotDefinedDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
119119
export const useGetNotDefinedKey = "GetNotDefined";
120120
export const UseGetNotDefinedKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useGetNotDefinedKey, ...(queryKey ?? [clientOptions])];
121121
export type FindPetByIdDefaultResponse = Awaited<ReturnType<typeof findPetById>>["data"];
122122
export type FindPetByIdQueryResult<TData = FindPetByIdDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
123123
export const useFindPetByIdKey = "FindPetById";
124-
export const UseFindPetByIdKeyFn = (clientOptions: Options<unknown, true>, queryKey?: Array<unknown>) => [useFindPetByIdKey, ...(queryKey ?? [clientOptions])];
124+
export const UseFindPetByIdKeyFn = (clientOptions: Options<FindPetByIdData, true>, queryKey?: Array<unknown>) => [useFindPetByIdKey, ...(queryKey ?? [clientOptions])];
125125
export type FindPaginatedPetsDefaultResponse = Awaited<ReturnType<typeof findPaginatedPets>>["data"];
126126
export type FindPaginatedPetsQueryResult<TData = FindPaginatedPetsDefaultResponse, TError = unknown> = UseQueryResult<TData, TError>;
127127
export const useFindPaginatedPetsKey = "FindPaginatedPets";
128-
export const UseFindPaginatedPetsKeyFn = (clientOptions: Options<unknown, true> = {}, queryKey?: Array<unknown>) => [useFindPaginatedPetsKey, ...(queryKey ?? [clientOptions])];
128+
export const UseFindPaginatedPetsKeyFn = (clientOptions: Options<FindPaginatedPetsData, true> = {}, queryKey?: Array<unknown>) => [useFindPaginatedPetsKey, ...(queryKey ?? [clientOptions])];
129129
export type AddPetMutationResult = Awaited<ReturnType<typeof addPet>>;
130130
export const useAddPetKey = "AddPet";
131131
export const UseAddPetKeyFn = (mutationKey?: Array<unknown>) => [useAddPetKey, ...(mutationKey ?? [])];

tests/__snapshots__/generate.test.ts.snap

+8-3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ import type {
1414
getNotDefined,
1515
postNotDefined,
1616
} from "../requests/services.gen";
17+
import type {
18+
FindPaginatedPetsData,
19+
FindPetByIdData,
20+
FindPetsData,
21+
} from "../requests/types.gen";
1722
export type FindPetsDefaultResponse = Awaited<
1823
ReturnType<typeof findPets>
1924
>["data"];
@@ -23,7 +28,7 @@ export type FindPetsQueryResult<
2328
> = UseQueryResult<TData, TError>;
2429
export const useFindPetsKey = "FindPets";
2530
export const UseFindPetsKeyFn = (
26-
clientOptions: Options<unknown, true> = {},
31+
clientOptions: Options<FindPetsData, true> = {},
2732
queryKey?: Array<unknown>,
2833
) => [useFindPetsKey, ...(queryKey ?? [clientOptions])];
2934
export type GetNotDefinedDefaultResponse = Awaited<
@@ -47,7 +52,7 @@ export type FindPetByIdQueryResult<
4752
> = UseQueryResult<TData, TError>;
4853
export const useFindPetByIdKey = "FindPetById";
4954
export const UseFindPetByIdKeyFn = (
50-
clientOptions: Options<unknown, true>,
55+
clientOptions: Options<FindPetByIdData, true>,
5156
queryKey?: Array<unknown>,
5257
) => [useFindPetByIdKey, ...(queryKey ?? [clientOptions])];
5358
export type FindPaginatedPetsDefaultResponse = Awaited<
@@ -59,7 +64,7 @@ export type FindPaginatedPetsQueryResult<
5964
> = UseQueryResult<TData, TError>;
6065
export const useFindPaginatedPetsKey = "FindPaginatedPets";
6166
export const UseFindPaginatedPetsKeyFn = (
62-
clientOptions: Options<unknown, true> = {},
67+
clientOptions: Options<FindPaginatedPetsData, true> = {},
6368
queryKey?: Array<unknown>,
6469
) => [useFindPaginatedPetsKey, ...(queryKey ?? [clientOptions])];
6570
export type AddPetMutationResult = Awaited<ReturnType<typeof addPet>>;

0 commit comments

Comments
 (0)