feat: [lexer]: implemented hypothesis tests fot lexer

Author: j-jodczyk

image_formatter/lexer/lexer.py

@@ -99,7 +99,9 @@ def verify_special_signs(cls, signs: Tuple[str]) -> bool:
         Raises:
             InvalidConfigCharacterError: when invalid character is found
         """
-        # todo - check (possibly everything might be valid)
+        invalid_chars = [" ", "(", ")"]
+        if any([sign in invalid_chars for sign in signs]):
+            raise InvalidConfigCharacterError("<space>", [])
         return True
 
     @classmethod

tests/lexer/test_hypothesis_lexer.py

@@ -10,17 +10,17 @@
 
 
 def special_sign():
-    chars_to_exclude = ["\n", "\r", "\r\n", "\x0b", "\v", "\f"] + list("@#$%&~>?+=:") + list("-_.~:/?#[]@!$&'()*+,;=%")
+    chars_to_exclude = ["\n", "\r", "@", "/", ".", " ", "(", ")", "&"]
     return st.text(min_size=1, max_size=1).filter(lambda s: all(char not in s for char in chars_to_exclude))
 
 
 def special_sign_tuples():
-    return st.tuples(special_sign(), special_sign())
+    return st.tuples(special_sign(), special_sign(), special_sign())
 
 
 @given(special_sign_tuples())
 def test_given_text_when_tags_not_separated_by_spaces_then_tokens_returned(special_signs):
-    text = f"@tag1(url1.png)@one{special_signs[0]}more{special_signs[1]}tag&and_word"
+    text = f"@tag1(url1.png)@one{special_signs[0]}more{special_signs[1]}tag&and{special_signs[2]}word"
     fp = io.StringIO(text)
     lexer = Lexer(fp, special_signs=special_signs)
     tokens = get_all_tokens(lexer)
@@ -31,13 +31,6 @@ def test_given_text_when_tags_not_separated_by_spaces_then_tokens_returned(speci
         TokenType.T_CHAR,
         TokenType.T_LITERAL,
     ]
-    assert [token.string for token in tokens] == [
-        "tag1",
-        "url1.png",
-        "one-more-tag",
-        "&",
-        "and_word",
-    ]
     assert [token.position for token in tokens] == [
         Position(1, 1),
         Position(1, 6),
@@ -47,8 +40,9 @@ def test_given_text_when_tags_not_separated_by_spaces_then_tokens_returned(speci
     ]
 
 
-def test_given_complex_text_with_special_chars_then_sequence_of_tokens_is_returned():
-    text = "word1, word2 $$ @tag1-tag \n\n @tag2(start-of/url.png)"
+@given(special_sign_tuples())
+def test_given_complex_text_with_special_chars_then_sequence_of_tokens_is_returned(special_signs):
+    text = f"word1& word2 && @tag1{special_signs[0]}tag \n\n @tag2(start{special_signs[1]}of/url.png)"
     expected_types = [
         TokenType.T_LITERAL,
         TokenType.T_CHAR,
@@ -66,23 +60,6 @@ def test_given_complex_text_with_special_chars_then_sequence_of_tokens_is_return
         TokenType.T_IMAGE_SIZE_TAG,
         TokenType.T_IMAGE_URL,
     ]
-    expected_strings = [
-        "word1",
-        ",",
-        " ",
-        "word2",
-        " ",
-        "$",
-        "$",
-        " ",
-        "tag1-tag",
-        " ",
-        "\n",
-        "\n",
-        " ",
-        "tag2",
-        "start-of/url.png",
-    ]
     expected_positions = [
         Position(1, 1),
         Position(1, 6),
@@ -101,10 +78,9 @@ def test_given_complex_text_with_special_chars_then_sequence_of_tokens_is_return
         Position(3, 7),
     ]
     fp = io.StringIO(text)
-    lexer = Lexer(fp)
+    lexer = Lexer(fp, special_signs=special_signs)
     tokens = get_all_tokens(lexer)
     assert len(tokens) == len(expected_types)
     assert len(tokens) == len(expected_positions)
     assert [token.type for token in tokens] == expected_types
-    assert [token.string for token in tokens] == expected_strings
     assert [token.position for token in tokens] == expected_positions

tests/lexer/test_unit_lexer.py

@@ -230,7 +230,7 @@ def test_when_literal_starts_with_digit_then_literal_token_without_starting_digi
 
 
 def test_given_text_when_tags_not_separated_by_spaces_then_tokens_returned():
-    text = "@tag1(url1.png)@one0more-tag&and_word"
+    text = "@tag1(url1.png)@one-more-tag&and_word"
     fp = io.StringIO(text)
     lexer = Lexer(fp)
     tokens = get_all_tokens(lexer)
@@ -425,7 +425,7 @@ def test_given_invalid_newline_characters_then_exception_is_raised():
         Lexer.verify_newline_characters(invalid_chars)
 
 
-@pytest.mark.parametrize("chars", [("-", "~", "?"), ("&", "*", ">"), (":", "/", ",")])
+@pytest.mark.parametrize("chars", [("-", "~", "?"), ("&", "*"), (":", "/", ",")])
 def test_given_valid_additional_path_signs_then_verify_returns_true(chars):
     assert Lexer.verify_additional_path_signs(chars) == True