Skip to content

Commit 84e58b5

Browse files
committed
fix top-k and top-p not working at all. fixes #3
1 parent 8cb0782 commit 84e58b5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

scripts/promptgen.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def get_model_path(name):
5555

5656

5757
def generate_batch(input_ids, min_length, max_length, num_beams, temperature, repetition_penalty, length_penalty, sampling_mode, top_k, top_p):
58-
top_p = int(top_p) if sampling_mode == 'Top P' else None
58+
top_p = float(top_p) if sampling_mode == 'Top P' else None
5959
top_k = int(top_k) if sampling_mode == 'Top K' else None
6060

6161
outputs = current.model.generate(
@@ -171,7 +171,7 @@ def add_tab():
171171
model_selection = gr.Dropdown(label="Model", elem_id="promptgen_model", value=available_models[0], choices=["None"] + available_models)
172172

173173
with FormRow():
174-
sampling_mode = gr.Radio(label="Sampling mode", elem_id="promptgen_sampling_mode", value="Top K", choices=["Top K", "Top P"], type="index")
174+
sampling_mode = gr.Radio(label="Sampling mode", elem_id="promptgen_sampling_mode", value="Top K", choices=["Top K", "Top P"])
175175
top_k = gr.Slider(label="Top K", elem_id="promptgen_top_k", value=12, minimum=1, maximum=50, step=1)
176176
top_p = gr.Slider(label="Top P", elem_id="promptgen_top_p", value=0.15, minimum=0, maximum=1, step=0.001)
177177

0 commit comments

Comments
 (0)