Skip to content

Commit 4c7f4b9

Browse files
committed
fix: $refs.popper can be null initially
Related to histoire-dev/histoire#206
1 parent 5f08f6f commit 4c7f4b9

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/floating-vue/src/components/Popper.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default () => defineComponent({
7171

7272
referenceNode: {
7373
type: Function,
74-
required: true,
74+
default: null,
7575
},
7676

7777
popperNode: {
@@ -478,7 +478,7 @@ export default () => defineComponent({
478478
this.$_preventShow = false
479479

480480
// Nodes
481-
this.$_referenceNode = this.referenceNode()
481+
this.$_referenceNode = this.referenceNode?.() ?? this.$el
482482
this.$_targetNodes = this.targetNodes().filter(e => e.nodeType === e.ELEMENT_NODE)
483483
this.$_popperNode = this.popperNode()
484484
this.$_innerNode = this.$_popperNode.querySelector('.v-popper__inner')

packages/floating-vue/src/components/PopperWrapper.vue

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
}"
1717
:theme="finalTheme"
1818
:target-nodes="getTargetNodes"
19-
:reference-node="() => $refs.popper.$el"
2019
:popper-node="() => $refs.popperContent.$el"
2120
:class="[
2221
themeClass,
@@ -86,7 +85,7 @@ export default defineComponent({
8685
8786
methods: {
8887
getTargetNodes () {
89-
return Array.from(this.$refs.popper.$el.children)
88+
return Array.from(this.$el.children)
9089
.filter(node => node !== this.$refs.popperContent.$el)
9190
},
9291
},

0 commit comments

Comments
 (0)