fix: rewrote HWA handling

enabled by default on >=28

Author: farfromrefug

package.json

@@ -42,9 +42,9 @@
         "@nativescript/types-android": "7.0.4",
         "@nativescript/types-ios": "7.0.4",
         "@nativescript/webpack": "3.0.5",
-        "@nativescript-community/ui-canvas": "4.0.17",
-        "@nativescript-community/gesturehandler": "^0.1.22",
-        "@nativescript-community/tween": "0.0.11",
+        "@nativescript-community/ui-canvas": "4.0.25",
+        "@nativescript-community/gesturehandler": "^0.1.23",
+        "@nativescript-community/tween": "0.0.12",
         "@tweenjs/tween.js": "18.6.0",
         "@types/node": "^14.6.4",
         "@types/tween.js": "^18.5.1",
@@ -68,4 +68,4 @@
         ]
     },
     "dependencies": {}
-}
+}

plugin/package.json

@@ -28,10 +28,10 @@
     "main": "charts/index.js",
     "typings": "charts/index.d.ts",
     "dependencies": {
-        "@nativescript-community/gesturehandler": "^0.1.22",
-        "@nativescript-community/tween": "0.0.11",
-        "@nativescript-community/ui-canvas": "^4.0.17",
+        "@nativescript-community/gesturehandler": "^0.1.23",
+        "@nativescript-community/tween": "0.0.12",
+        "@nativescript-community/ui-canvas": "^4.0.25",
         "downsample": "^1.3.0",
         "number-format.js": "^2.0.9"
     }
-}
+}

src/charting/charts/BarLineChartBase.ts

@@ -1351,7 +1351,6 @@ export abstract class BarLineChartBase<U extends Entry, D extends IBarLineScatte
 
     public getHighestVisibleX() {
         this.getTransformer(AxisDependency.LEFT).getValuesByTouchPoint(this.mViewPortHandler.contentRight(), this.mViewPortHandler.contentBottom(), this.posForGetHighestVisibleX);
-        // console.log('getHighestVisibleX', this.mViewPortHandler.contentRight(), this.mViewPortHandler.contentBottom(), this.posForGetHighestVisibleX, this.mXAxis.mAxisMaximum);
         const result = Math.min(this.mXAxis.mAxisMaximum, this.posForGetHighestVisibleX.x);
 
         return result;

src/charting/charts/Chart.ts

@@ -149,8 +149,6 @@ export abstract class Chart<U extends Entry, D extends IDataSet<U>, T extends Ch
      */
     constructor() {
         super();
-        // disable by default. Render is so much better!
-        this.hardwareAccelerated = false;
         this.init();
     }
 
@@ -1593,7 +1591,7 @@ export abstract class Chart<U extends Entry, D extends IDataSet<U>, T extends Ch
      * @param enabled
      */
     public setHardwareAccelerationEnabled(enabled) {
-        Utils.setHardwareAccelerationEnabled(this.nativeViewProtected, enabled);
+        this.hardwareAccelerated = enabled;
     }
 
     // protected onDetachedFromWindow() {

src/charting/utils/Utils.ts

@@ -12,6 +12,14 @@ if (global.isAndroid) {
     FloatConstructor = interop.sizeof(interop.types.id) === 4 ? Float32Array : Float64Array;
 }
 
+
+let SDK_INT = -1;
+function getSDK() {
+    if (SDK_INT === -1) {
+        SDK_INT = android.os.Build.VERSION.SDK_INT;
+    }
+    return SDK_INT;
+}
 /**
  * Utilities class that has some helper methods. Needs to be initialized by
  * calling Utils.init(...) before usage. Inside the Chart.init() method, this is
@@ -616,9 +624,6 @@ export namespace Utils {
         };
     }
 
-    //export function getSDKInt() {
-    //     return android.os.Build.VERSION.SDK_INT;
-    // }
 
     export function logMethod(target, key, descriptor) {
         // save a reference to the original method this way we keep the values currently in the
@@ -706,18 +711,10 @@ export namespace Utils {
 
     export function clipPathSupported() {
         if (global.isAndroid) {
-            return android.os.Build.VERSION.SDK_INT >= 18;
+            return getSDK() >= 18;
         }
         return false;
     }
-    export function setHardwareAccelerationEnabled(view: android.view.View, enabled) {
-        if (global.isAndroid) {
-            if (view) {
-                if (enabled) view.setLayerType(android.view.View.LAYER_TYPE_HARDWARE, null);
-                else view.setLayerType(android.view.View.LAYER_TYPE_SOFTWARE, null);
-            }
-        }
-    }
 
     /**
      * Calculates the sum across all values of the given array.