Skip to content

Commit 4163f68

Browse files
committed
fix: customRenderer methods are optional
1 parent e6c1eff commit 4163f68

File tree

7 files changed

+17
-17
lines changed

7 files changed

+17
-17
lines changed

src/charting/charts/BarChart.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import { BaseCustomRenderer } from '../renderer/DataRenderer';
1717
const LOG_TAG = 'BarChart';
1818

1919
export interface CustomRenderer extends BaseCustomRenderer {
20-
drawBar: (c: Canvas, e: BarEntry, dataSet: IBarDataSet, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
21-
drawHighlight: (c: Canvas, e: Highlight, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
20+
drawBar?: (c: Canvas, e: BarEntry, dataSet: IBarDataSet, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
21+
drawHighlight?: (c: Canvas, e: Highlight, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
2222
}
2323

2424
export class BarChart extends BarLineChartBase<Entry, BarDataSet, BarData> implements BarDataProvider {

src/charting/charts/BubbleChart.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import { BaseCustomRenderer } from '../renderer/DataRenderer';
99
import { BarLineChartBase } from './BarLineChartBase';
1010

1111
export interface CustomRenderer extends BaseCustomRenderer {
12-
drawBubble: (c: Canvas, e: BubbleEntry, cx: number, cy: number, radius: number, paint: Paint) => void;
13-
drawHighlight: (c: Canvas, e: Highlight, cx: number, cy: number, radius: number, paint: Paint) => void;
12+
drawBubble?: (c: Canvas, e: BubbleEntry, cx: number, cy: number, radius: number, paint: Paint) => void;
13+
drawHighlight?: (c: Canvas, e: Highlight, cx: number, cy: number, radius: number, paint: Paint) => void;
1414
}
1515

1616
/**

src/charting/charts/CandleStickChart.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import { BaseCustomRenderer } from '../renderer/DataRenderer';
99
import { BarLineChartBase } from './BarLineChartBase';
1010

1111
export interface CustomRenderer extends BaseCustomRenderer {
12-
drawShadows: (c: Canvas, e: CandleEntry, lines: number[], paint: Paint) => void;
13-
drawOpened: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
14-
drawClosed: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
15-
drawEqual: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
16-
drawLines: (c: Canvas, e: CandleEntry, range: number[], open: number[], close: number[], paint: Paint) => void;
17-
drawHighlight: (c: Canvas, e: Highlight, set: ICandleDataSet, paint: Paint) => void;
12+
drawShadows?: (c: Canvas, e: CandleEntry, lines: number[], paint: Paint) => void;
13+
drawOpened?: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
14+
drawClosed?: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
15+
drawEqual?: (c: Canvas, e: CandleEntry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
16+
drawLines?: (c: Canvas, e: CandleEntry, range: number[], open: number[], close: number[], paint: Paint) => void;
17+
drawHighlight?: (c: Canvas, e: Highlight, set: ICandleDataSet, paint: Paint) => void;
1818
}
1919
/**
2020
* Financial chart type that draws candle-sticks (OHCL chart).

src/charting/charts/PieChart.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import { BaseCustomRenderer } from '../renderer/DataRenderer';
1616
const LOG_TAG = 'PieChart';
1717

1818
export interface CustomRenderer extends BaseCustomRenderer {
19-
drawSlice: (c: Canvas, e: Entry, slice: Path, paint: Paint) => void;
20-
drawHighlight: (c: Canvas, e: Highlight, slice: Path, paint: Paint) => void;
19+
drawSlice?: (c: Canvas, e: Entry, slice: Path, paint: Paint) => void;
20+
drawHighlight?: (c: Canvas, e: Highlight, slice: Path, paint: Paint) => void;
2121
}
2222
/**
2323
* View that represents a pie chart. Draws cake like slices.

src/charting/charts/RadarChart.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import { BaseCustomRenderer } from '../renderer/DataRenderer';
1515

1616
const LOG_TAG = 'RadarChart';
1717
export interface CustomRenderer extends BaseCustomRenderer {
18-
drawRadar: (c: Canvas, e: Entry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
19-
drawHighlight: (c: Canvas, e: Highlight, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
18+
drawRadar?: (c: Canvas, e: Entry, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
19+
drawHighlight?: (c: Canvas, e: Highlight, left: number, top: number, right: number, bottom: number, paint: Paint) => void;
2020
}
2121
/**
2222
* Implementation of the RadarChart, a "spidernet"-like chart. It works best

src/charting/charts/ScatterChart.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import { ViewPortHandler } from '../utils/ViewPortHandler';
1111
import { BaseCustomRenderer } from '../renderer/DataRenderer';
1212

1313
export interface CustomRenderer extends BaseCustomRenderer {
14-
drawShape: (c: Canvas, e: Entry, dataSet: IScatterDataSet, viewPortHandler: ViewPortHandler, x: number, y: number, paint: Paint) => void;
15-
drawHighlight: (c: Canvas, e: Highlight, set: IScatterDataSet, paint: Paint) => void;
14+
drawShape?: (c: Canvas, e: Entry, dataSet: IScatterDataSet, viewPortHandler: ViewPortHandler, x: number, y: number, paint: Paint) => void;
15+
drawHighlight?: (c: Canvas, e: Highlight, set: IScatterDataSet, paint: Paint) => void;
1616
}
1717

1818
export enum ScatterShape {

src/charting/renderer/DataRenderer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { ViewPortHandler } from '../utils/ViewPortHandler';
88
import { Renderer } from './Renderer';
99

1010
export interface BaseCustomRenderer {
11-
drawValue: (c: Canvas, valueText: string, x: number, y: number, color: Color, paint: Paint) => void;
11+
drawValue?: (c: Canvas, valueText: string, x: number, y: number, color: Color, paint: Paint) => void;
1212
}
1313

1414
/**

0 commit comments

Comments
 (0)