Skip to content

Commit b26e2c7

Browse files
committed
fix: HorizontalBarChart X bounds check was incorrect.
1 parent 6a3c239 commit b26e2c7

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
"clean": "rimraf ./plugin/**/*.d.ts ./plugin/**/*.js ./plugin/**/*.js.map plugin/node_modules plugin/package-lock.json",
88
"build": "cp README.md plugin/ && rm -f .tsbuildinfo && npm run tsc",
99
"setup": "npm i && ts-patch install",
10-
"demo.ios": "npm i && npm run tsc && cd demo && tns run ios",
11-
"demo.android": "npm i && npm run tsc && cd demo && tns run android",
10+
"demo.ios": "npm i && npm run tsc && cd demo && ns run ios",
11+
"demo.android": "npm i && npm run tsc && cd demo && ns run android",
1212
"clean.demo": "rimraf demo/hooks demo/node_modules demo/platforms",
13-
"demo.ios.vue": "npm i && npm run tsc && cd demo_vue && tns run ios",
14-
"demo.android.vue": "npm i && npm run tsc && cd demo_vue && tns run android",
13+
"demo.ios.vue": "npm i && npm run tsc && cd demo_vue && ns run ios",
14+
"demo.android.vue": "npm i && npm run tsc && cd demo_vue && ns run android",
1515
"clean.demo.vue": "rimraf demo_vue/hooks demo_vue/node_modules demo_vue/platforms",
1616
"plugin.watch.tsc": "npm run tsc -- -w",
1717
"plugin.watch": "npm run plugin.watch.tsc",

src/charting/renderer/HorizontalBarChartRenderer.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export class HorizontalBarChartRenderer extends BarChartRenderer {
161161
break;
162162
}
163163

164-
if (!this.mViewPortHandler.isInBoundsX(buffer.buffer[isInverted ? j : (j + 2)])) {
164+
if (!this.mViewPortHandler.isInBoundsX(buffer.buffer[isInverted ? (j + 2) : j])) {
165165
continue;
166166
}
167167

@@ -221,7 +221,7 @@ export class HorizontalBarChartRenderer extends BarChartRenderer {
221221
break;
222222
}
223223

224-
if (!this.mViewPortHandler.isInBoundsX(buffer.buffer[isInverted ? bufferIndex : (bufferIndex + 2)])) {
224+
if (!this.mViewPortHandler.isInBoundsX(buffer.buffer[isInverted ? (bufferIndex + 2) : bufferIndex])) {
225225
continue;
226226
}
227227

0 commit comments

Comments
 (0)