fix(ios): ensure verticalTextAlignment works in all cases

farfromrefug · farfromrefug · commit 05ed697ad415 · 2024-02-12T13:57:38.000+01:00
diff --git a/src/label.ios.ts b/src/label.ios.ts
@@ -446,13 +446,21 @@ export class Label extends LabelBase {
             this.setMeasuredDimension(widthAndState, heightAndState);
         }
     }
-    _onSizeChanged() {
-        super._onSizeChanged();
+    onLayout(left, top, right, bottom) {
+        super.onLayout(left, top, right, bottom);
+        // we do on every layout pass or we might be out of sync
         this.updateVerticalAlignment();
         if (this.autoFontSize) {
             this.updateAutoFontSize({ textView: this.nativeTextViewProtected });
         }
     }
+    // _onSizeChanged() {
+    //     super._onSizeChanged();
+    //     this.updateVerticalAlignment();
+    //     if (this.autoFontSize) {
+    //         this.updateAutoFontSize({ textView: this.nativeTextViewProtected });
+    //     }
+    // }
     // _htmlTappable = false;
     // _htmlTapGestureRecognizer;
     // updateInteractionState(hasLink: boolean = false) {

Original file line number	Diff line number	Diff line change
`@@ -446,13 +446,21 @@ export class Label extends LabelBase {`
`446`	`446`	`this.setMeasuredDimension(widthAndState, heightAndState);`
`447`	`447`	`}`
`448`	`448`	`}`
`449`		`- _onSizeChanged() {`
`450`		`- super._onSizeChanged();`
	`449`	`+ onLayout(left, top, right, bottom) {`
	`450`	`+ super.onLayout(left, top, right, bottom);`
	`451`	`+ // we do on every layout pass or we might be out of sync`
`451`	`452`	`this.updateVerticalAlignment();`
`452`	`453`	`if (this.autoFontSize) {`
`453`	`454`	`this.updateAutoFontSize({ textView: this.nativeTextViewProtected });`
`454`	`455`	`}`
`455`	`456`	`}`
	`457`	`+ // _onSizeChanged() {`
	`458`	`+ // super._onSizeChanged();`
	`459`	`+ // this.updateVerticalAlignment();`
	`460`	`+ // if (this.autoFontSize) {`
	`461`	`+ // this.updateAutoFontSize({ textView: this.nativeTextViewProtected });`
	`462`	`+ // }`
	`463`	`+ // }`
`456`	`464`	`// _htmlTappable = false;`
`457`	`465`	`// _htmlTapGestureRecognizer;`
`458`	`466`	`// updateInteractionState(hasLink: boolean = false) {`