Skip to content

ADF 2.5 issue with intl polyfill #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaspereden opened this issue Aug 21, 2018 · 4 comments
Closed

ADF 2.5 issue with intl polyfill #3710

kaspereden opened this issue Aug 21, 2018 · 4 comments

Comments

@kaspereden
Copy link
Contributor

Type of issue: (check with "[x]")

  • New feature request
  • Bug
  • Support request
  • Documentation

Current behaviour:
In the browser console I am getting the following message:

Uncaught ReferenceError: global is not defined
at Object../node_modules/intl/index.js (index.js:2)
at webpack_require (bootstrap:81)
at Object../src/polyfills.ts (zone.js:3060)
at webpack_require (bootstrap:81)
at Object.4 (polyfills.ts:77)
at webpack_require (bootstrap:81)
at checkDeferredModules (bootstrap:43)
at Array.webpackJsonpCallback [as push] (bootstrap:30)
at polyfills.js:1

It is gone after I've disabled the intl polyfill. But that is probably not the way to go...

Expected behavior:
no messages

Steps to reproduce the issue:
I've upgraded from adf 2.4 to 2.5

Component name and version:

Browser and version:

Node version (for build issues):
v10.8.0

New feature request:

@DenysVuika
Copy link
Contributor

@kaspereden according to this thread, this one is not needed anymore with 6.x: angular/angular-cli#9920

@kaspereden
Copy link
Contributor Author

@DenisVuyka cool, we also do not face extra problems by this. So it only needs to be removed from the generator

@DenysVuika
Copy link
Contributor

@kaspereden already updated generators, thanks 👍

@kaspereden
Copy link
Contributor Author

kaspereden commented Aug 31, 2018

cool lets close this

-edit- too late already done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants