Skip to content

Bug: Toastr Error Does Not Display When Editing Cell #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bennnjamin opened this issue Mar 1, 2017 · 6 comments
Closed

Bug: Toastr Error Does Not Display When Editing Cell #1101

bennnjamin opened this issue Mar 1, 2017 · 6 comments
Labels
bug in progress

Comments

@bennnjamin
Copy link
Contributor

If you go to Insert & Cell edit example here http://allenfang.github.io/react-bootstrap-table/example.html#advance

When you edit cell directly (not insert), the cell shakes but no Toastr error message appears. This used to work before 3.0.0.
@AllenFang
Copy link
Owner

I'll check this out, thanks :)

@CharlieCharlieCharlieCharlie
Copy link

In my code I return true in the beforeCellEdit but I do not get a toastr underneath my edited field, just plain text of the title and message.

capture

@bennnjamin
Copy link
Contributor Author

@AllenFang any update on this? The bug is still present

@AllenFang
Copy link
Owner

sorry for lately fix... very busy for my work and I've fixed it on my local, will be release soon. Sorry

@AllenFang
Copy link
Owner

Fixed on v3.1.2, please have a look, thanks

@bennnjamin
Copy link
Contributor Author

@AllenFang The code looks good. I will test today. Thanks for your quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CharlieCharlieCharlieCharlie @AllenFang @bennnjamin