Skip to content

Row disappears on delete if it shouldn't #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silver17 opened this issue Sep 29, 2017 · 3 comments
Closed

Row disappears on delete if it shouldn't #1655

silver17 opened this issue Sep 29, 2017 · 3 comments

Comments

@silver17
Copy link

silver17 commented Sep 29, 2017

In my table, I have defined deleting row like this:

 remote(obj) {
    obj.cellEdit = true;
    obj.insertRow = true;
    obj.dropRow = true;
    return obj;
  }

deleteRow(currentRows) {
    this.props.removeParameters(Entities.COUNTRIES, currentRows);
  }

 const options = {
      onDeleteRow: ::this.deleteRow,

I'm using reducers to handle state changes. If I try to delete some row which can't be deleted, I get an error from backend. But before getting that error, the row disappears for some reason from UI. And it's not coming from my reducer where I have defined what to do in case rowDelete action. I managed to track things to ReactUpdates.js under react-dom and this part makes the row gone

ReactReconciler.performUpdateIfNecessary(component, transaction.reconcileTransaction, updateBatchNumber);

But I have no idea why. Any ideas?

PS. After the row is gone, I receive the error from backend and display the alert.

Tried with v3.4.4 and v4.0.5

@AllenFang
Copy link
Owner

@silver17 hmm.. it's a critical bug,,,, I'll fix it soon, thanks

@AllenFang
Copy link
Owner

@silver17 sorry for lately reply, this was fixed on v4.1.0

@silver17
Copy link
Author

Thanks, seems to fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants