Issues of table search

[liqili]

I have found some issues about Table Search functionality.
1.The search key matched the hidden column.
2.I met problems following the below steps.
a.SelectAll records
b.Search by some condition.Some records are filtered.
c.I still get all records including filtered records when submitting to backend .

[AllenFang]

@liqili, I'll check this out. Thanks :)

[liqili]

@AllenFang Thanks very much.Regarding issue 2,I think it's not a problem if I can get the record sets displayed in the screen.

[AllenFang]

@liqili, for issue 2, you can try this:

var options  = {
  //...
  afterSearch: function(searchText, result) {
      //result is the data which filtered
  }
}

//...

<BootstrapTable options={options}>

[liqili]

@AllenFang Fine.Thank you!

[AllenFang]

@liqili, if work, please let me know :)

[liqili]

@AllenFang Thanks,It satisfied my requirements.

[AllenFang]

Great, I will fix issues 1

[AllenFang]

For issues 1, I've fixed it and released on v1.5.2

[chriscostello9]

Maybe list a good example for those using ES6 linting, in your docs:

options={{sortName: 'name',
  sortOrder: 'asc',
  afterSearch: (searchText, result) => {
    this.afterSearch(result);
  }
}}

Then, the afterSearch function to do whatever it is you want:

afterSearch(result) {
  const filtered = new Set(result.map(item => item.myPropName));

  this.setState({
    filtered: selected,
  });
}

[AllenFang]

@chriscostello9, thanks your feedback. I'll improve my document in near future :)

[waiter]

@AllenFang
Since the search can't search text in object, so can't you add a switch to enable the search key matched the hidden column? Or other better ways??

I've read the source code, the targetVal.toString() makes the object to [Object object] ...

[AllenFang]

@waiter, I think it's hard to search on an object. But if I make the searching on hidden column configurable, is that helpful for you?

[AllenFang]

@waiter, btw, your case is common, if you really need a object can be searched, A customization search can achieve your requirement. I mean just handle search and state outside the react-bootstrap-table.

[waiter]

@AllenFang
Make the searching on hidden column configurable is what I want. So could you add this feature.
Handle search and state outside the react-bootstrap-table means I should reset the BootstrapTable's prop data every time?

[AllenFang]

@waiter, I think I can add this feature in near future.

Handle search and state outside the react-bootstrap-table means I should reset the BootstrapTable's prop data every time?

yes, after searching, just render new props data on table

[waiter]

@AllenFang
OK, thank you~

[AllenFang]

@waiter, @liqili I've released the newest version v1.6.0
Currently, hidden column can be searched by default, if you want some hidden cant be searched, add searchable={false} on <TableHeaderColumn>

Sorry for this functionality changed, feel free to discuss with me

[waiter]

@AllenFang
Great to hear that! Thank you~
But, it doesn't work. Did you write the wrong logical operator??
you write !hidden && searchable to check wheather it can be searched,
but I think it should be !hidden || searchable since when column is hidden, then hidden={true}.
Pleace check it ...

[AllenFang]

I made a big mistake, I will solve this issue quickly. Thanks

[waiter]

@AllenFang
Great~

[AllenFang]

@liqili @waiter, sorry for my mistake, v1.6.1 is the newest version, hidden column can be searched by default. you can set searchable={false} to disable. Feel free to ask anything

[waiter]

@AllenFang
Thank you, it works now~~

[nguyenchanhnghia]

hi all. I have a issue of search table. search is not working when data of cell is object. How to search realizable?
Thank!

[AllenFang]

@nguyenchanhnghia, sorry for lately reply, I've opened #569 and have a plane to deal with it.