-
Notifications
You must be signed in to change notification settings - Fork 775
Question about devtool: '#eval-source-map' #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@TonyVeigel, follow #217. btw, any consideration for |
Thanks. I just know like #217 that the eval devtools should not be used for production only for development. I see now even on the newest build it is production. |
Just a discussion, like the problem of #217, how to solve it in your opinion |
I will think of a solution, in the meantime though, I would say it should be pulled out of production because it causes issues with minifying, performance, etc.. |
Is this going to be pulled out of production? Before : 95.9 KB, after: 521 KB now: 611 KB For a table. eval-source-map |
So for production, we can use cheap-source-map or cheap-module-source-map. all we have to do is change the Webpack production configuration of the repo. |
There doesn't need to be a solution right now. eval-source-map is not supposed to be in production for various reason but yet it is and people continue to download this library. I can do a PR with it removed but @AllenFang i guess needs a solution first. |
@TonyVeigel as I said, cheap-module-source-map can be used in production. I'm doing a PR and try to improve other things on the build system. |
I'll merge #347(Provided by @staminaloops ) and release quickly. Sorry for make this issue still remain. |
Released on v2.0.3, the size reduce to about ~110 KB. @TonyVeigel, sorry for this issues that I dont fixed activity, I thinks there's something wrong actually but thanks @staminaloops fixed. I'll close this issues, feel free to ask any question :) |
Why is this in production?
The text was updated successfully, but these errors were encountered: