Skip to content

Question about devtool: '#eval-source-map' #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TonyVeigel opened this issue Mar 9, 2016 · 10 comments
Closed

Question about devtool: '#eval-source-map' #325

TonyVeigel opened this issue Mar 9, 2016 · 10 comments

Comments

@TonyVeigel
Copy link

Why is this in production?

@AllenFang
Copy link
Owner

@TonyVeigel, follow #217. btw, any consideration for eval-source-map?

@TonyVeigel
Copy link
Author

Thanks. I just know like #217 that the eval devtools should not be used for production only for development. I see now even on the newest build it is production.

@AllenFang
Copy link
Owner

Just a discussion, like the problem of #217, how to solve it in your opinion

@TonyVeigel
Copy link
Author

I will think of a solution, in the meantime though, I would say it should be pulled out of production because it causes issues with minifying, performance, etc..

@TonyVeigel
Copy link
Author

Is this going to be pulled out of production? Before : 95.9 KB, after: 521 KB now: 611 KB For a table.

eval-source-map
Bundles the source code modules using "eval", with nested, complete source map in the same file. This option does generate a full featured source map without a big impact on build time, but with performance and security drawbacks in the JavaScript execution. While it's a good option for using during development, this option should never be used in production.

@staminaloops
Copy link
Contributor

So for production, we can use cheap-source-map or cheap-module-source-map. all we have to do is change the Webpack production configuration of the repo.

@TonyVeigel
Copy link
Author

There doesn't need to be a solution right now. eval-source-map is not supposed to be in production for various reason but yet it is and people continue to download this library. I can do a PR with it removed but @AllenFang i guess needs a solution first.

@staminaloops
Copy link
Contributor

@TonyVeigel as I said, cheap-module-source-map can be used in production. I'm doing a PR and try to improve other things on the build system.

@AllenFang
Copy link
Owner

I'll merge #347(Provided by @staminaloops ) and release quickly. Sorry for make this issue still remain.

@AllenFang
Copy link
Owner

Released on v2.0.3, the size reduce to about ~110 KB. @TonyVeigel, sorry for this issues that I dont fixed activity, I thinks there's something wrong actually but thanks @staminaloops fixed. I'll close this issues, feel free to ask any question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants