Skip to content

Error after upgrading from 2.0.2 to 2.0.3 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
staskorz opened this issue Mar 23, 2016 · 5 comments
Closed

Error after upgrading from 2.0.2 to 2.0.3 #354

staskorz opened this issue Mar 23, 2016 · 5 comments
Labels

Comments

@staskorz
Copy link
Contributor

The following error is received after upgrading from 2.0.2 to 2.0.3:

Uncaught Error: Cannot find module 'events'

Reverting back to 2.0.2 resolves the issue.

@AllenFang
Copy link
Owner

HI @staskorz , when the error messages be throw?

@staminaloops
Copy link
Contributor

OK I spotted the problem. https://github.com/AllenFang/react-bootstrap-table/blob/master/src/store/TableDataStore.js

We are using event emitter but we didn't declare it as a dependency. Do we really need it? We could use other way of handling events without depending on event emitter

@AllenFang
Copy link
Owner

@staminaloops, I thinks it time to drop TableDataSet, I dont want to keep support this feature anyway. I'll handle this. Thanks your finding!

@staskorz
Copy link
Contributor Author

Hi @AllenFang , it occurs on component load.

Thanks.

@AllenFang
Copy link
Owner

Released on v2.1.0. I've removed the TableDataSet module from our project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants