Skip to content

pagination covers table when setting maxheight #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grigored opened this issue Aug 30, 2016 · 7 comments
Closed

pagination covers table when setting maxheight #666

grigored opened this issue Aug 30, 2016 · 7 comments
Labels

Comments

@grigored
Copy link

See attached image.
screen shot 2016-08-30 at 3 51 35 am

@grigored
Copy link
Author

Turns out the .react-bs-container-body gets the same maxheight as the .react-bs-table. If we set .react-bs-container-body to maxheight-40px, it looks fine.

@AllenFang AllenFang added the bug label Aug 31, 2016
@AllenFang
Copy link
Owner

@grigored, I'll check this out. Thanks

@AllenFang
Copy link
Owner

@grigored, what's version of react-bootstrap-table you used?

@grigored
Copy link
Author

grigored commented Sep 6, 2016

@AllenFang I had 2.5.0, just upgraded to 2.5.1, same problem. My current fix is:

    let reactBsContainerBody = document.getElementsByClassName("react-bs-container-body");
    for (var i = 0; i < reactBsContainerBody.length; i++ ) {
        reactBsContainerBody[i].style['max-height'] = (window.innerHeight - 245) + 'px';
    }

@AllenFang
Copy link
Owner

@grigored, thanks, one more question, what value of maxheight you given? and did you configured hieght?

@grigored
Copy link
Author

grigored commented Sep 7, 2016

Sorry for forgetting to mention this, the table maxheight is (window.innerHeight - 200) + 'px';, and height is not configured. Thanks for your help.

@AllenFang
Copy link
Owner

@grigored, Fixed on v2.5.2, make it a try 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants