Fixed PR comments ydb-platform#3

Author: Alnen

ydb/core/protos/flat_scheme_op.proto

@@ -1806,7 +1806,7 @@ message TExternalTableDescription {
     optional string Location = 6;
     repeated TColumnDescription Columns = 7;
     optional bytes Content = 8;
-    optional bool ReplaceIfExists = 9;
+    optional bool ReplaceIfExists = 9; // Only applicable for `create external table` operation
 }
 
 // Access without authorization

ydb/library/yql/sql/v1/format/sql_format_ut.cpp

@@ -354,6 +354,8 @@ Y_UNIT_TEST_SUITE(CheckSqlFormatter) {
              "CREATE EXTERNAL DATA SOURCE usEr WITH (a = \"b\");\n"},
              {"creAte exTernAl daTa SouRce if not exists usEr With (a = \"b\")",
              "CREATE EXTERNAL DATA SOURCE IF NOT EXISTS usEr WITH (a = \"b\");\n"},
+             {"creAte oR rePlaCe exTernAl daTa SouRce usEr With (a = \"b\")",
+             "CREATE OR REPLACE EXTERNAL DATA SOURCE usEr WITH (a = \"b\");\n"},
              {"create external data source eds with (a=\"a\",b=\"b\",c = true)",
              "CREATE EXTERNAL DATA SOURCE eds WITH (\n\ta = \"a\",\n\tb = \"b\",\n\tc = TRUE\n);\n"},
              {"alter external data source eds set a true, reset (b, c), set (x=y, z=false)",
@@ -388,6 +390,8 @@ Y_UNIT_TEST_SUITE(CheckSqlFormatter) {
         TCases cases = {
             {"creAte exTernAl TabLe usEr (a int) With (a = \"b\")",
              "CREATE EXTERNAL TABLE usEr (\n\ta int\n)\nWITH (a = \"b\");\n"},
+             {"creAte oR rePlaCe exTernAl TabLe usEr (a int) With (a = \"b\")",
+             "CREATE OR REPLACE EXTERNAL TABLE usEr (\n\ta int\n)\nWITH (a = \"b\");\n"},
             {"creAte exTernAl TabLe iF NOt Exists usEr (a int) With (a = \"b\")",
              "CREATE EXTERNAL TABLE IF NOT EXISTS usEr (\n\ta int\n)\nWITH (a = \"b\");\n"},
             {"create external table user (a int) with (a=\"b\",c=\"d\")",

ydb/library/yql/sql/v1/sql_query.cpp

@@ -184,7 +184,7 @@ bool TSqlQuery::Statement(TVector<TNodePtr>& blocks, const TRule_sql_stmt_core&
 
             if (replaceIfExists && tableType != ETableType::ExternalTable) {
                 Context().Error(GetPos(rule.GetBlock2().GetToken1()))
-                    << "OR REPLACE is supported only for EXTERNAL DATA SOURCE and EXTERNAL TABLE";
+                    << "OR REPLACE feature is supported only for EXTERNAL DATA SOURCE and EXTERNAL TABLE";
                 return false;
             }
 

ydb/library/yql/sql/v1/sql_ut.cpp

@@ -5606,6 +5606,26 @@ Y_UNIT_TEST_SUITE(ExternalDataSource) {
         UNIT_ASSERT_VALUES_EQUAL(1, elementStat["Write"]);
     }
 
+    Y_UNIT_TEST(CreateOrReplaceForUnsupportedTableTypesShouldFail) {
+        ExpectFailWithError(R"sql(
+                USE plato;
+                CREATE OR REPLACE TABLE t (a int32 not null, primary key(a, a));
+            )sql" , "<main>:3:23: Error: OR REPLACE feature is supported only for EXTERNAL DATA SOURCE and EXTERNAL TABLE\n");
+
+        ExpectFailWithError(R"sql(
+                USE plato;
+                CREATE OR REPLACE TABLE t (
+                    Key Uint64,
+                    Value1 String,
+                    PRIMARY KEY (Key)
+                )
+                WITH (
+                    STORE = COLUMN,
+                    AUTO_PARTITIONING_MIN_PARTITIONS_COUNT = 10
+                );
+            )sql" , "<main>:3:23: Error: OR REPLACE feature is supported only for EXTERNAL DATA SOURCE and EXTERNAL TABLE\n");
+    }
+
     Y_UNIT_TEST(CreateExternalDataSourceWithBadArguments) {
         ExpectFailWithError(R"sql(
                 USE plato;