Fixed PR comments ydb-platform#1

Author: Alnen

ydb/core/fq/libs/compute/common/config.h

@@ -28,9 +28,6 @@ class TComputeConfig {
                          "Activation percentage must be either 0 or 100");
             }
         }
-        for (size_t i = 0; i < ComputeConfig.SupportedComputeYDBFeaturesSize(); ++i) {
-          SupportedSyntaxFeatures.insert(ComputeConfig.GetSupportedComputeYDBFeatures(i));
-        }
     }
 
     NFq::NConfig::EComputeType GetComputeType(const FederatedQuery::QueryContent::QueryType queryType, const TString& scope) const {
@@ -176,14 +173,13 @@ class TComputeConfig {
         }
     }
 
-    [[nodiscard]] bool IsYDBSyntaxFeatureSupported(NConfig::ESupportedComputeYDBFeatures feature) const {
-      return SupportedSyntaxFeatures.contains(feature);
+    [[nodiscard]] bool IsReplaceIfExistsSyntaxSupported() const {
+      return ComputeConfig.GetSupportedComputeYDBFeatures().GetReplaceIfExists();
     }
 
 private:
     NFq::NConfig::TComputeConfig ComputeConfig;
     NFq::NConfig::EComputeType DefaultCompute;
-    std::unordered_set<NConfig::ESupportedComputeYDBFeatures> SupportedSyntaxFeatures{};
 };
 
 } /* NFq */

ydb/core/fq/libs/config/protos/compute.proto

@@ -83,14 +83,14 @@ message TComputeMapping {
     TActivationPercentage Activation = 3;
 }
 
-enum ESupportedComputeYDBFeatures {
-    REPLACE_IF_EXISTS = 0;
+message TSupportedComputeYDBFeatures {
+    bool ReplaceIfExists = 1;
 }
 
 message TComputeConfig {
     TInPlaceCompute InPlace = 1;
     TYdbCompute Ydb = 2;
     EComputeType DefaultCompute = 3;
     repeated TComputeMapping ComputeMapping = 4;
-    repeated ESupportedComputeYDBFeatures SupportedComputeYDBFeatures = 5;
+    TSupportedComputeYDBFeatures SupportedComputeYDBFeatures = 5;
 }

ydb/core/fq/libs/control_plane_proxy/actors/ydb_schema_query_actor.cpp

@@ -575,7 +575,7 @@ IActor* MakeCreateConnectionActor(
         statements.push_back(TSchemaQueryTask{
             .SQL = MakeCreateExternalDataSourceQuery(
                 connectionContent, signer, commonConfig,
-                computeConfig.IsYDBSyntaxFeatureSupported(REPLACE_IF_EXISTS)),
+                computeConfig.IsReplaceIfExistsSyntaxSupported()),
             .ScheduleErrorRecoverySQLGeneration =
                 withoutRollback ? NoRecoverySQLGeneration()
                                 : alreadyExistRecoveryActorFactoryMethod,
@@ -636,7 +636,7 @@ NActors::IActor* MakeModifyConnectionActor(
                                     newConnectionContent.name(),
                                     signer);
 
-        bool replaceSupported = computeConfig.IsYDBSyntaxFeatureSupported(REPLACE_IF_EXISTS);
+        bool replaceSupported = computeConfig.IsReplaceIfExistsSyntaxSupported();
         if (replaceSupported &&
             oldConnectionContent.name() == newConnectionContent.name()) {
             // CREATE OR REPLACE
@@ -833,7 +833,7 @@ NActors::IActor* MakeCreateBindingActor(
         statements.push_back(TSchemaQueryTask{
             .SQL = TString{MakeCreateExternalDataTableQuery(
                 bindingContent, externalSourceName,
-                computeConfig.IsYDBSyntaxFeatureSupported(REPLACE_IF_EXISTS))},
+                computeConfig.IsReplaceIfExistsSyntaxSupported())},
             .ScheduleErrorRecoverySQLGeneration =
                 withoutRollback ? NoRecoverySQLGeneration()
                                 : alreadyExistRecoveryActorFactoryMethod,
@@ -881,7 +881,7 @@ NActors::IActor* MakeModifyBindingActor(
         auto sourceName   = request->Get()->ConnectionContent->name();
         auto oldTableName = request->Get()->OldBindingContent->name();
 
-        bool replaceSupported = computeConfig.IsYDBSyntaxFeatureSupported(REPLACE_IF_EXISTS);
+        bool replaceSupported = computeConfig.IsReplaceIfExistsSyntaxSupported();
         if (replaceSupported &&
             oldTableName == request->Get()->Request.content().name()) {
           // CREATE OR REPLACE