Compare closing style #30
SebastianStehle
started this conversation in
General
Replies: 1 comment 1 reply
-
Was about to write that you could probably do this with a custom compare, but you beat me to it. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
I have a bug report here: SebastianStehle/mjml-net#161
The bug has not been detected by our tests because and seems to be related to self closing elements, so
vs
Is is possible to configure the comparer for that?
Furthermore: Do you have some ideas for these things?
https://github.com/SebastianStehle/mjml-net/blob/main/Tests/Internal/AssertHelpers.cs#L107
It is about conditional comments and how html entities are handled. Perhaps another option to the text comparer to normalize all entities before comparing them would work? I really dislike this part of my code.
Beta Was this translation helpful? Give feedback.
All reactions