Add savingPinsEnabled to MetricSettings and add a related selector

Author: roseayeon

tensorboard/webapp/metrics/store/metrics_selectors.ts

@@ -382,6 +382,11 @@ export const getMetricsImageShowActualSize = createSelector(
   (settings): boolean => settings.imageShowActualSize
 );
 
+export const getMetricsSavingPinsEnabled = createSelector(
+  selectSettings,
+  (settings): boolean => settings.savingPinsEnabled
+);
+
 export const getMetricsTagFilter = createSelector(
   selectMetricsState,
   (state): string => state.tagFilter

tensorboard/webapp/metrics/store/metrics_selectors_test.ts

@@ -1298,6 +1298,18 @@ describe('metrics selectors', () => {
       );
       expect(selectors.getMetricsCardMinWidth(state)).toBe(400);
     });
+
+    it('returns savingPinsEnabled when called getMetricsSavingPinsEnabled', () => {
+      selectors.getMetricsSavingPinsEnabled.release();
+      const state = appStateFromMetricsState(
+        buildMetricsState({
+          settings: buildMetricsSettingsState({
+            savingPinsEnabled: false,
+          }),
+        })
+      );
+      expect(selectors.getMetricsSavingPinsEnabled(state)).toBe(false);
+    });
   });
 
   describe('getMetricsTagFilter', () => {

tensorboard/webapp/metrics/store/metrics_types.ts

@@ -246,6 +246,7 @@ export interface MetricsSettings {
   imageContrastInMilli: number;
   imageShowActualSize: boolean;
   histogramMode: HistogramMode;
+  savingPinsEnabled: boolean;
 }
 
 export interface MetricsNonNamespacedState {
@@ -287,4 +288,5 @@ export const METRICS_SETTINGS_DEFAULT: MetricsSettings = {
   imageContrastInMilli: 1000,
   imageShowActualSize: false,
   histogramMode: HistogramMode.OFFSET,
+  savingPinsEnabled: true,
 };

tensorboard/webapp/metrics/testing.ts

@@ -59,6 +59,7 @@ export function buildMetricsSettingsState(
     imageContrastInMilli: 123,
     imageShowActualSize: true,
     histogramMode: HistogramMode.OFFSET,
+    savingPinsEnabled: true,
     ...overrides,
   };
 }