fix: Defuse assert when flattening after diagnosed error (#2233)

dcodeIO · web-flow · commit 1c806f57bda1 · 2022-03-23T01:10:42.000+01:00
diff --git a/src/module.ts b/src/module.ts
@@ -1452,7 +1452,10 @@ export class Module {
         }
       }
       let singleType = getExpressionType(single);
-      assert(singleType == TypeRef.Unreachable || singleType == type);
+      if (singleType != TypeRef.Unreachable && singleType != type) {
+        // can happen when there was a diagnostic prior
+        return this.unreachable();
+      }
       return single;
     }
     return this.block(null, stmts, type);

Original file line number	Diff line number	Diff line change
`@@ -1452,7 +1452,10 @@ export class Module {`
`1452`	`1452`	`}`
`1453`	`1453`	`}`
`1454`	`1454`	`let singleType = getExpressionType(single);`
`1455`		`- assert(singleType == TypeRef.Unreachable \|\| singleType == type);`
	`1455`	`+ if (singleType != TypeRef.Unreachable && singleType != type) {`
	`1456`	`+ // can happen when there was a diagnostic prior`
	`1457`	`+ return this.unreachable();`
	`1458`	`+ }`
`1456`	`1459`	`return single;`
`1457`	`1460`	`}`
`1458`	`1461`	`return this.block(null, stmts, type);`