Skip to content

[BUG] asc --version now returns 0.0.0 #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willemneal opened this issue Jul 7, 2020 · 5 comments · Fixed by #1414
Closed

[BUG] asc --version now returns 0.0.0 #1379

willemneal opened this issue Jul 7, 2020 · 5 comments · Fixed by #1414

Comments

@willemneal
Copy link
Contributor

As the title says since the new semantic publishing was set up the version returned is 0.0.0.

@dcodeIO
Copy link
Member

dcodeIO commented Jul 7, 2020

The SDK had a similar issue that I was able to solve by building it upon postversion. Ideally there'd be a way to determine and update the version prior to publishing using semantic-release, but not sure if they support that.

@dcodeIO dcodeIO added the bug label Jul 7, 2020
@MaxGraey
Copy link
Member

MaxGraey commented Jul 7, 2020

How about add custom script (or npm hook) which will trigger after semantic-release publish and write ver string to some version.json file for example? Or is there an easier way?

@dcodeIO
Copy link
Member

dcodeIO commented Jul 7, 2020

We can'd modify the package anymore after it has been published, unfortunately. Also, dist files can't load a separate file via require or similar but must bundle everything for browser usage. Best integration point I found so far is postversion, which executes exactly in between determining the version and publishing the package during execution of semantic-release.

@dcodeIO
Copy link
Member

dcodeIO commented Jul 7, 2020

@github-actions
Copy link

🎉 This issue has been resolved in version 0.14.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants