-
-
Notifications
You must be signed in to change notification settings - Fork 670
Enhancement: optimize tests of parameter type parser according to test coverage report #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Phase: 1 |
I found it could be a issue for test:
the result is we get 1003 error as expected but we still can see it is compiled as below: I am not sure if it is reasonable, because extends from anonymous function type is meaningless. |
The parser/compiler try to recover from errors that will ultimately cause compilation to fail, so more than one error can be diagnosed. Here, the recognizable parts of the AST are still produced during parsing, but their compilation is not attempted. |
@dcodeIO and I find a small issue here.
|
I guess this can be one PR, along the lines of "fix: X and add additional tests". Does this sound OK? |
@dcodeIO |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions! |
@dcodeIO |
Hi Guys,
I tried to enhance the test coverage, there is some missing part according to coverage report.
I might commit several commits or PRs under this issue, please let me know if it is not suitable.
Thank you.
Regards
The text was updated successfully, but these errors were encountered: