Fix broken Head302Test (#1421)

* Update Head302Test to show it is actually failing

This test had the following defects which caused it to falsely pass:

* Jetty requires a handler to explicitly indicate it has handled the
request by calling Request.setHandled(true).  Otherwise the server will
return 404.
* The test did not configure the client to follow redirects.
* The test itself wasn't asserting anything useful beyond that the
request did not time out.  To ensure the redirect was followed, it needs
to assert the expected response status code from the redirected location
is received.

* Fix broken Head302Test

The test now verifies that a HEAD redirected via 302 is switched to GET
per [1].

[1] #989

Author: ssoloff

Diff for: client/src/test/java/org/asynchttpclient/Head302Test.java

@@ -16,6 +16,8 @@
 package org.asynchttpclient;
 
 import static org.asynchttpclient.Dsl.*;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
 import static org.testng.Assert.fail;
 
 import java.io.IOException;
@@ -45,15 +47,15 @@ public class Head302Test extends AbstractBasicTest {
     private static class Head302handler extends AbstractHandler {
         public void handle(String s, org.eclipse.jetty.server.Request r, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
             if ("HEAD".equalsIgnoreCase(request.getMethod())) {
-                if (request.getPathInfo().endsWith("_moved")) {
-                    response.setStatus(HttpServletResponse.SC_OK);
-                } else {
-                    response.setStatus(HttpServletResponse.SC_FOUND); // 302
-                    response.setHeader("Location", request.getPathInfo() + "_moved");
-                }
-            } else { // this handler is to handle HEAD request
+                response.setStatus(HttpServletResponse.SC_FOUND); // 302
+                response.setHeader("Location", request.getPathInfo() + "_moved");
+            } else if ("GET".equalsIgnoreCase(request.getMethod())) {
+                response.setStatus(HttpServletResponse.SC_OK);
+            } else {
                 response.setStatus(HttpServletResponse.SC_FORBIDDEN);
             }
+
+            r.setHandled(true);
         }
     }
 
@@ -64,19 +66,23 @@ public AbstractHandler configureHandler() throws Exception {
 
     @Test(groups = "standalone")
     public void testHEAD302() throws IOException, BrokenBarrierException, InterruptedException, ExecutionException, TimeoutException {
-        try (AsyncHttpClient client = asyncHttpClient()) {
+        AsyncHttpClientConfig clientConfig = new DefaultAsyncHttpClientConfig.Builder().setFollowRedirect(true).build();
+        try (AsyncHttpClient client = asyncHttpClient(clientConfig)) {
             final CountDownLatch l = new CountDownLatch(1);
             Request request = head("http://localhost:" + port1 + "/Test").build();
 
-            client.executeRequest(request, new AsyncCompletionHandlerBase() {
+            Response response = client.executeRequest(request, new AsyncCompletionHandlerBase() {
                 @Override
                 public Response onCompleted(Response response) throws Exception {
                     l.countDown();
                     return super.onCompleted(response);
                 }
             }).get(3, TimeUnit.SECONDS);
 
-            if (!l.await(TIMEOUT, TimeUnit.SECONDS)) {
+            if (l.await(TIMEOUT, TimeUnit.SECONDS)) {
+                assertEquals(response.getStatusCode(), HttpServletResponse.SC_OK);
+                assertTrue(response.getUri().getPath().endsWith("_moved"));
+            } else {
                 fail("Timeout out");
             }
         }