Drop own Cookie in favor of Netty's one, close #1297

Motivation:

AHC’s fast Cookie parser has been contributed to Netty.
Let’s drop our own implementation so:
* I don’t have to maintain both implementations
* people using Netty as HTTP server don’t have so many implementations
to deal with.

Modifications:

*Drop AHC’s Cookie, CookieDecoder and CookieEncoder

Result:

Less code to maintain, one single implementation around for Netty + AHC
users

Author: slandelle

client/src/main/java/org/asynchttpclient/DefaultRequest.java

@@ -15,6 +15,7 @@
 
 import static org.asynchttpclient.util.MiscUtils.isNonEmpty;
 import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.cookie.Cookie;
 import io.netty.resolver.NameResolver;
 
 import java.io.File;
@@ -28,7 +29,6 @@
 import java.util.Map;
 
 import org.asynchttpclient.channel.ChannelPoolPartitioning;
-import org.asynchttpclient.cookie.Cookie;
 import org.asynchttpclient.proxy.ProxyServer;
 import org.asynchttpclient.request.body.generator.BodyGenerator;
 import org.asynchttpclient.request.body.multipart.Part;

client/src/main/java/org/asynchttpclient/Request.java

@@ -17,6 +17,7 @@
 package org.asynchttpclient;
 
 import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.cookie.Cookie;
 import io.netty.resolver.NameResolver;
 
 import java.io.File;
@@ -27,7 +28,6 @@
 import java.util.List;
 
 import org.asynchttpclient.channel.ChannelPoolPartitioning;
-import org.asynchttpclient.cookie.Cookie;
 import org.asynchttpclient.proxy.ProxyServer;
 import org.asynchttpclient.request.body.generator.BodyGenerator;
 import org.asynchttpclient.request.body.multipart.Part;

client/src/main/java/org/asynchttpclient/RequestBuilderBase.java

@@ -20,6 +20,7 @@
 import static org.asynchttpclient.util.MiscUtils.isNonEmpty;
 import io.netty.handler.codec.http.DefaultHttpHeaders;
 import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.cookie.Cookie;
 import io.netty.resolver.DefaultNameResolver;
 import io.netty.resolver.NameResolver;
 import io.netty.util.concurrent.ImmediateEventExecutor;
@@ -36,7 +37,6 @@
 import java.util.Map;
 
 import org.asynchttpclient.channel.ChannelPoolPartitioning;
-import org.asynchttpclient.cookie.Cookie;
 import org.asynchttpclient.proxy.ProxyServer;
 import org.asynchttpclient.request.body.generator.BodyGenerator;
 import org.asynchttpclient.request.body.generator.ReactiveStreamsBodyGenerator;
@@ -290,12 +290,12 @@ public T addCookie(Cookie cookie) {
     }
 
     public T addOrReplaceCookie(Cookie cookie) {
-        String cookieKey = cookie.getName();
+        String cookieKey = cookie.name();
         boolean replace = false;
         int index = 0;
         lazyInitCookies();
         for (Cookie c : this.cookies) {
-            if (c.getName().equals(cookieKey)) {
+            if (c.name().equals(cookieKey)) {
                 replace = true;
                 break;
             }

client/src/main/java/org/asynchttpclient/Response.java

@@ -17,6 +17,7 @@
 package org.asynchttpclient;
 
 import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.cookie.Cookie;
 
 import java.io.InputStream;
 import java.net.SocketAddress;
@@ -25,7 +26,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import org.asynchttpclient.cookie.Cookie;
 import org.asynchttpclient.netty.NettyResponse;
 import org.asynchttpclient.uri.Uri;