Skip to content

Investigate DNS failures in testMaxTotalConnectionsTest #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TomGranot opened this issue Dec 12, 2020 · 1 comment
Open

Investigate DNS failures in testMaxTotalConnectionsTest #1754

TomGranot opened this issue Dec 12, 2020 · 1 comment
Assignees
@TomGranot
Labels
Defect

Comments

@TomGranot
Copy link
Contributor

See #1753 and elaborate more given time.

@slandelle you mentioned this has to do with Travis's DNS resolution, but I can confirm this fails also on my own machine and on GitHub actions. If you have any other insight / past experience with this do tell, but I'm leaving it here for later exploration.
@TomGranot TomGranot self-assigned this Dec 12, 2020
@TomGranot
Copy link
Contributor Author

#1753 fixes that in a rather stupid way - by making the test a bit more granular to avoid any reliance on the exact exception thrown during the test. Instead, it now opts to observe the cause of the exception and use that as well as the exception type.

I'd like to keep this open to revisit the test eventually since I feel it's going to come back and bite me in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomGranot TomGranot

Labels
Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomGranot