Skip to content

Commit 8d47871

Browse files
committed
feat(config): fix exporter uri type
Signed-off-by: Shichao Nie <[email protected]>
1 parent 5860a39 commit 8d47871

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

core/src/main/java/kafka/automq/AutoMQConfig.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import kafka.server.KafkaConfig;
1616

1717
import org.apache.kafka.common.config.ConfigDef;
18+
import org.apache.kafka.common.config.types.Password;
1819
import org.apache.kafka.common.utils.Utils;
1920

2021
import com.automq.stream.s3.ByteBufAllocPolicy;
@@ -36,6 +37,7 @@
3637
import static org.apache.kafka.common.config.ConfigDef.Type.BOOLEAN;
3738
import static org.apache.kafka.common.config.ConfigDef.Type.INT;
3839
import static org.apache.kafka.common.config.ConfigDef.Type.LONG;
40+
import static org.apache.kafka.common.config.ConfigDef.Type.PASSWORD;
3941
import static org.apache.kafka.common.config.ConfigDef.Type.STRING;
4042

4143
public class AutoMQConfig {
@@ -266,7 +268,7 @@ public static void define(ConfigDef configDef) {
266268
.define(AutoMQConfig.S3_NETWORK_REFILL_PERIOD_MS_CONFIG, INT, S3_REFILL_PERIOD_MS, MEDIUM, AutoMQConfig.S3_NETWORK_REFILL_PERIOD_MS_DOC)
267269
.define(AutoMQConfig.S3_TELEMETRY_METRICS_LEVEL_CONFIG, STRING, "INFO", MEDIUM, AutoMQConfig.S3_TELEMETRY_METRICS_LEVEL_DOC)
268270
.define(AutoMQConfig.S3_TELEMETRY_EXPORTER_REPORT_INTERVAL_MS_CONFIG, INT, S3_METRICS_EXPORTER_REPORT_INTERVAL_MS, MEDIUM, AutoMQConfig.S3_TELEMETRY_EXPORTER_REPORT_INTERVAL_MS_DOC)
269-
.define(AutoMQConfig.S3_TELEMETRY_METRICS_EXPORTER_URI_CONFIG, STRING, null, HIGH, AutoMQConfig.S3_TELEMETRY_METRICS_EXPORTER_URI_DOC)
271+
.define(AutoMQConfig.S3_TELEMETRY_METRICS_EXPORTER_URI_CONFIG, PASSWORD, null, HIGH, AutoMQConfig.S3_TELEMETRY_METRICS_EXPORTER_URI_DOC)
270272
.define(AutoMQConfig.S3_TELEMETRY_METRICS_BASE_LABELS_CONFIG, STRING, null, MEDIUM, AutoMQConfig.S3_TELEMETRY_METRICS_BASE_LABELS_DOC)
271273
.define(AutoMQConfig.S3_BACK_PRESSURE_ENABLED_CONFIG, BOOLEAN, AutoMQConfig.S3_BACK_PRESSURE_ENABLED_DEFAULT, MEDIUM, AutoMQConfig.S3_BACK_PRESSURE_ENABLED_DOC)
272274
.define(AutoMQConfig.S3_BACK_PRESSURE_COOLDOWN_MS_CONFIG, LONG, AutoMQConfig.S3_BACK_PRESSURE_COOLDOWN_MS_DEFAULT, MEDIUM, AutoMQConfig.S3_BACK_PRESSURE_COOLDOWN_MS_DOC)
@@ -367,7 +369,8 @@ private static String genWALConfig(KafkaConfig config) {
367369
}
368370

369371
private static String genMetricsExporterURI(KafkaConfig config) {
370-
String uri = config.getString(S3_TELEMETRY_METRICS_EXPORTER_URI_CONFIG);
372+
Password pwd = config.getPassword(S3_TELEMETRY_METRICS_EXPORTER_URI_CONFIG);
373+
String uri = pwd.value();
371374
if (uri == null) {
372375
uri = buildMetrixExporterURIWithOldConfigs(config);
373376
}

0 commit comments

Comments
 (0)