Skip to content

fix: correct cosmosdb trigger types #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix: correct cosmosdb trigger types #266

wants to merge 1 commit into from

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Nov 18, 2024 •
edited
Loading

vrdmr
vrdmr reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this break an existing app that would have taken dependency on time?

@hallvictoria
Copy link
Contributor Author

Would this break an existing app that would have taken dependency on time?

datetime is one of the built-in Python modules -- not a dependency of the library. I don't think we recommend apps taking dependencies on those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr left review comments

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar will be requested when the pull request is marked ready for review gavin-aguiar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect types in cosmos_db_trigger decorator
2 participants
@hallvictoria @vrdmr