Skip to content

Commit eaf464e

Browse files
eliagradypraries880
eliagrady
authored and
praries880
committed
Remove security contact phone field mandatory fields (#4417)
* Remove security contact phone field mandatory fields * Update security contact examples * Update security contact examples - refactored * Update security contact examples - refactored - second iteration
1 parent 2389da3 commit eaf464e

10 files changed

+138
-24
lines changed

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/CreateSecurityContact_example.json renamed to ‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/CreateSecurityContact_full_example.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
"parameters": {
33
"api-version": "2017-08-01-preview",
44
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5-
"securityContactName": "john",
5+
"securityContactName": "default1",
66
"securityContact": {
7-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
8-
"name": "john",
7+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
8+
"name": "default1",
99
"type": "Microsoft.Security/securityContacts",
1010
"properties": {
1111
"email": "[email protected]",
@@ -18,8 +18,8 @@
1818
"responses": {
1919
"200": {
2020
"body": {
21-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
22-
"name": "john",
21+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
22+
"name": "default1",
2323
"type": "Microsoft.Security/securityContacts",
2424
"properties": {
2525
"email": "[email protected]",

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/CreateSecurityContact_min_example.json

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
{
2+
"parameters": {
3+
"api-version": "2017-08-01-preview",
4+
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5+
"securityContactName": "default2",
6+
"securityContact": {
7+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
8+
"name": "default2",
9+
"type": "Microsoft.Security/securityContacts",
10+
"properties": {
11+
"email": "[email protected]",
12+
"alertNotifications": "On",
13+
"alertsToAdmins": "On"
14+
}
15+
}
16+
},
17+
"responses": {
18+
"200": {
19+
"body": {
20+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
21+
"name": "default2",
22+
"type": "Microsoft.Security/securityContacts",
23+
"properties": {
24+
"email": "[email protected]",
25+
"alertNotifications": "On",
26+
"alertsToAdmins": "On"
27+
}
28+
}
29+
}
30+
}
31+
}

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/DeleteSecurityContact_example.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"parameters": {
33
"api-version": "2017-08-01-preview",
44
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5-
"securityContactName": "john"
5+
"securityContactName": "default1"
66
},
77
"responses": {
88
"204": {

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContact_example.json renamed to ‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContact_full_example.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
"parameters": {
33
"api-version": "2017-08-01-preview",
44
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5-
"securityContactName": "john"
5+
"securityContactName": "default1"
66
},
77
"responses": {
88
"200": {
99
"body": {
10-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
11-
"name": "john",
10+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
11+
"name": "default1",
1212
"type": "Microsoft.Security/securityContacts",
1313
"properties": {
1414
"email": "[email protected]",

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContact_min_example.json

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
{
2+
"parameters": {
3+
"api-version": "2017-08-01-preview",
4+
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5+
"securityContactName": "default2"
6+
},
7+
"responses": {
8+
"200": {
9+
"body": {
10+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
11+
"name": "default2",
12+
"type": "Microsoft.Security/securityContacts",
13+
"properties": {
14+
"email": "[email protected]",
15+
"alertNotifications": "On",
16+
"alertsToAdmins": "On"
17+
}
18+
}
19+
}
20+
}
21+
}

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContactsSubscription_example.json renamed to ‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContactsSubscription_full_example.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
"200": {
88
"body": {
99
"value": [{
10-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
11-
"name": "john",
10+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
11+
"name": "default1",
1212
"type": "Microsoft.Security/securityContacts",
1313
"properties": {
1414
"email": "[email protected]",

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/GetSecurityContactsSubscription_min_example.json

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
{
2+
"parameters": {
3+
"api-version": "2017-08-01-preview",
4+
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23"
5+
},
6+
"responses": {
7+
"200": {
8+
"body": {
9+
"value": [{
10+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
11+
"name": "default2",
12+
"type": "Microsoft.Security/securityContacts",
13+
"properties": {
14+
"email": "[email protected]",
15+
"alertNotifications": "On",
16+
"alertsToAdmins": "On"
17+
}
18+
}]
19+
}
20+
}
21+
}
22+
}

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/UpdateSecurityContact_example.json renamed to ‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/UpdateSecurityContact_full_example.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
55
"securityContactName": "john",
66
"securityContact": {
7-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
8-
"name": "john",
7+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
8+
"name": "default1",
99
"type": "Microsoft.Security/securityContacts",
1010
"properties": {
1111
"phone": "(214)275-4038",
@@ -16,8 +16,8 @@
1616
"responses": {
1717
"200": {
1818
"body": {
19-
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/john",
20-
"name": "john",
19+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default1",
20+
"name": "default1",
2121
"type": "Microsoft.Security/securityContacts",
2222
"properties": {
2323
"email": "[email protected]",

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/examples/SecurityContacts/UpdateSecurityContact_min_example.json

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
{
2+
"parameters": {
3+
"api-version": "2017-08-01-preview",
4+
"subscriptionId": "20ff7fc3-e762-44dd-bd96-b71116dcdc23",
5+
"securityContactName": "default2",
6+
"securityContact": {
7+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
8+
"name": "default2",
9+
"type": "Microsoft.Security/securityContacts",
10+
"properties": {
11+
"alertNotifications": "On"
12+
}
13+
}
14+
},
15+
"responses": {
16+
"200": {
17+
"body": {
18+
"id": "/subscriptions/20ff7fc3-e762-44dd-bd96-b71116dcdc23/providers/Microsoft.Security/securityContacts/default2",
19+
"name": "default2",
20+
"type": "Microsoft.Security/securityContacts",
21+
"properties": {
22+
"email": "[email protected]",
23+
"alertNotifications": "On",
24+
"alertsToAdmins": "Off"
25+
}
26+
}
27+
}
28+
}
29+
}

‎specification/security/resource-manager/Microsoft.Security/preview/2017-08-01-preview/security.json

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,11 @@
235235
"/subscriptions/{subscriptionId}/providers/Microsoft.Security/securityContacts": {
236236
"get": {
237237
"x-ms-examples": {
238-
"Update security contact data": {
239-
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_example.json"
238+
"Update security contact data minimal": {
239+
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_min_example.json"
240+
},
241+
"Update security contact data full": {
242+
"$ref": "./examples/SecurityContacts/GetSecurityContactsSubscription_full_example.json"
240243
}
241244
},
242245
"tags": ["Security Contacts"],
@@ -269,8 +272,11 @@
269272
"/subscriptions/{subscriptionId}/providers/Microsoft.Security/securityContacts/{securityContactName}": {
270273
"get": {
271274
"x-ms-examples": {
272-
"Get security contact data": {
273-
"$ref": "./examples/SecurityContacts/GetSecurityContact_example.json"
275+
"Get security contact data minimal": {
276+
"$ref": "./examples/SecurityContacts/GetSecurityContact_min_example.json"
277+
},
278+
"Get security contact data full": {
279+
"$ref": "./examples/SecurityContacts/GetSecurityContact_full_example.json"
274280
}
275281
},
276282
"tags": ["Security Contacts"],
@@ -300,8 +306,11 @@
300306
},
301307
"put": {
302308
"x-ms-examples": {
303-
"Create security contact data": {
304-
"$ref": "./examples/SecurityContacts/CreateSecurityContact_example.json"
309+
"Create security contact data minimal": {
310+
"$ref": "./examples/SecurityContacts/CreateSecurityContact_min_example.json"
311+
},
312+
"Create security contact data full": {
313+
"$ref": "./examples/SecurityContacts/CreateSecurityContact_full_example.json"
305314
}
306315
},
307316
"tags": ["Security Contacts"],
@@ -361,8 +370,11 @@
361370
},
362371
"patch": {
363372
"x-ms-examples": {
364-
"Update security contact data": {
365-
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_example.json"
373+
"Update security contact data minimal": {
374+
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_min_example.json"
375+
},
376+
"Update security contact data full": {
377+
"$ref": "./examples/SecurityContacts/UpdateSecurityContact_full_example.json"
366378
}
367379
},
368380
"tags": ["Security Contacts"],
@@ -1179,7 +1191,6 @@
11791191
},
11801192
"required": [
11811193
"email",
1182-
"phone",
11831194
"alertNotifications",
11841195
"alertsToAdmins"
11851196
]

0 commit comments

Comments
 (0)