Skip to content

IMDS probe requests should throw CredentialUnavailableException for any response that is not valid json #41291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christothes opened this issue Jul 25, 2024 · 1 comment · May be fixed by #45101
Assignees
Milestone

Comments

@christothes
Copy link
Member

Currently we handle responses from IMDS under certain conditions by throwing CredentialUnavailableException. The purpose of this exception is to indicate to chained credentials, such as DefaultAzureCredential, that the credential selection process should not terminate and continue attempting credentials along the chain.

Please validate in our managed identity probe request implementation that any request, either successful or unsuccessful, containing content other than valid json should result in throwing CredentialUnavailableException.

@billwert billwert moved this from Untriaged to Not Started in Azure Identity SDK Improvements Aug 27, 2024
@billwert billwert added this to the 2024-10 milestone Aug 27, 2024
@billwert billwert moved this from Not Started to In Progress in Azure Identity SDK Improvements Oct 2, 2024
@billwert billwert modified the milestones: 2024-10, 2025-01 Oct 2, 2024
@billwert billwert modified the milestones: 2025-01, 2025-02 Feb 3, 2025
billwert added a commit to billwert/azure-sdk-for-java that referenced this issue Feb 7, 2025
@billwert billwert moved this from In Progress to Blocked in Azure Identity SDK Improvements Feb 8, 2025
@billwert billwert modified the milestones: 2025-02, 2025-03 Feb 8, 2025
@billwert
Copy link
Contributor

billwert commented Feb 8, 2025

Need a feature from MSAL. AzureAD/microsoft-authentication-library-for-java#907

@billwert billwert modified the milestones: 2025-03, 2025-04 Feb 26, 2025
@billwert billwert modified the milestones: 2025-04, 2025-05 Mar 17, 2025
@billwert billwert moved this from Blocked to Not Started in Azure Identity SDK Improvements Apr 14, 2025
@billwert billwert linked a pull request Apr 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Started
2 participants