Skip to content

Commit 051877a

Browse files
authored
[App Config] Skip flaky tests in live mode (#33313)
- "accepts operation options" tests are testing options passed into core than specific App Configuration features. Some of these tests have been flaky in live test pipeline only in windows environment. Skipping for now and we have created an issue to track this.
1 parent b9abd05 commit 051877a

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

sdk/appconfiguration/app-configuration/test/public/index.readonlytests.spec.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Licensed under the MIT License.
33

44
import type { Recorder } from "@azure-tools/test-recorder";
5-
import { isPlaybackMode } from "@azure-tools/test-recorder";
65
import {
76
assertThrowsAbortError,
87
assertThrowsRestError,
@@ -71,7 +70,7 @@ describe("AppConfigurationClient (set|clear)ReadOnly", () => {
7170
});
7271

7372
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
74-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
73+
it.skip("accepts operation options", async () => {
7574
// Recorder checks for the recording and complains before core-rest-pipeline could throw the AbortError (Recorder v2 should help here)
7675
await client.getConfigurationSetting({
7776
key: testConfigSetting.key,

sdk/appconfiguration/app-configuration/test/public/index.spec.ts

+6-7
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,7 @@ describe("AppConfigurationClient", () => {
173173
});
174174

175175
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
176-
it.skip("accepts operation options", async (ctx) => {
177-
if (isPlaybackMode()) ctx.skip();
176+
it.skip("accepts operation options", async () => {
178177
const key = recorder.variable(
179178
"addConfigTestTwice",
180179
`addConfigTestTwice${Math.floor(Math.random() * 1000)}`,
@@ -327,7 +326,7 @@ describe("AppConfigurationClient", () => {
327326
});
328327

329328
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
330-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
329+
it.skip("accepts operation options", async () => {
331330
// Recorder checks for the recording and complains before core-rest-pipeline could throw the AbortError (Recorder v2 should help here)
332331
const key = recorder.variable(
333332
"deleteConfigTest",
@@ -455,7 +454,7 @@ describe("AppConfigurationClient", () => {
455454
});
456455

457456
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
458-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
457+
it.skip("accepts operation options", async () => {
459458
const key = recorder.variable(
460459
"getConfigTest",
461460
`getConfigTest${Math.floor(Math.random() * 1000)}`,
@@ -1134,7 +1133,7 @@ describe("AppConfigurationClient", () => {
11341133
});
11351134

11361135
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
1137-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
1136+
it.skip("accepts operation options", async () => {
11381137
await assertThrowsAbortError(async () => {
11391138
const settingsIterator = client.listConfigurationSettings({
11401139
requestOptions: { timeout: 1 },
@@ -1310,7 +1309,7 @@ describe("AppConfigurationClient", () => {
13101309
});
13111310

13121311
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
1313-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
1312+
it.skip("accepts operation options", async () => {
13141313
await assertThrowsAbortError(async () => {
13151314
const iter = client.listRevisions({ labelFilter: labelA, requestOptions: { timeout: 1 } });
13161315
await iter.next();
@@ -1582,7 +1581,7 @@ describe("AppConfigurationClient", () => {
15821581
});
15831582

15841583
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
1585-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
1584+
it.skip("accepts operation options", async () => {
15861585
const key = recorder.variable(
15871586
`setConfigTestNA`,
15881587
`setConfigTestNA${Math.floor(Math.random() * 1000)}`,

sdk/appconfiguration/app-configuration/test/public/snapshot.spec.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT License.
33
import type { Recorder } from "@azure-tools/test-recorder";
4-
import { isPlaybackMode, testPollingOptions } from "@azure-tools/test-recorder";
4+
import { testPollingOptions } from "@azure-tools/test-recorder";
55
import type { AppConfigurationClient } from "../../src/appConfigurationClient.js";
66
import type {
77
ConfigurationSnapshot,
@@ -110,7 +110,7 @@ describe("AppConfigurationClient snapshot", () => {
110110
});
111111

112112
// Skipping all "accepts operation options flaky tests" https://github.com/Azure/azure-sdk-for-js/issues/26447
113-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
113+
it.skip("accepts operation options", async () => {
114114
await assertThrowsAbortError(async () => {
115115
await client.beginCreateSnapshotAndWait(snapshot1, {
116116
requestOptions: {
@@ -175,7 +175,7 @@ describe("AppConfigurationClient snapshot", () => {
175175
);
176176
});
177177

178-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
178+
it.skip("accepts operation options", async () => {
179179
await assertThrowsAbortError(async () => {
180180
await client.archiveSnapshot(newSnapshot.name, {
181181
requestOptions: {
@@ -201,7 +201,7 @@ describe("AppConfigurationClient snapshot", () => {
201201
await client.archiveSnapshot(newSnapshot.name);
202202
});
203203

204-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
204+
it.skip("accepts operation options", async () => {
205205
await assertThrowsAbortError(async () => {
206206
await client.recoverSnapshot(newSnapshot.name, {
207207
requestOptions: {
@@ -223,7 +223,7 @@ describe("AppConfigurationClient snapshot", () => {
223223
});
224224

225225
// Check issue https://github.com/Azure/azure-sdk-for-js/issues/26447
226-
it.skip("accepts operation options", { skip: isPlaybackMode() }, async () => {
226+
it.skip("accepts operation options", async () => {
227227
newSnapshot = await client.beginCreateSnapshotAndWait(snapshot1, testPollingOptions);
228228
await assertThrowsAbortError(async () => {
229229
await client.getSnapshot(newSnapshot.name, {

0 commit comments

Comments
 (0)