[Service Bus] calculate absolute expiry time based on time to live (#18289)

* update absolute expiry time

* remove unused import

* .\message.py

Author: swathipil

sdk/servicebus/azure-servicebus/azure/servicebus/_common/constants.py

@@ -161,6 +161,10 @@
 
 
 MESSAGE_PROPERTY_MAX_LENGTH = 128
+# .NET TimeSpan.MaxValue: 10675199.02:48:05.4775807
+MAX_DURATION_VALUE = 922337203685477
+# equivalent to .NET Date("9999-12-31T07:59:59.000Z").getTime() in ms
+MAX_ABSOLUTE_EXPIRY_TIME = 253402243199000
 
 
 class ServiceBusReceiveMode(str, Enum):

sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py

@@ -5,6 +5,7 @@
 # -------------------------------------------------------------------------
 # pylint: disable=too-many-lines
 
+import time
 import datetime
 import uuid
 import logging
@@ -34,6 +35,8 @@
     ANNOTATION_SYMBOL_SCHEDULED_ENQUEUE_TIME,
     ANNOTATION_SYMBOL_KEY_MAP,
     MESSAGE_PROPERTY_MAX_LENGTH,
+    MAX_ABSOLUTE_EXPIRY_TIME,
+    MAX_DURATION_VALUE
 )
 
 from ..exceptions import MessageSizeExceededError
@@ -277,11 +280,20 @@ def time_to_live(self, value):
             self._amqp_header = uamqp.message.MessageHeader()
         if value is None:
             self._amqp_header.time_to_live = value
+            if self._amqp_properties.absolute_expiry_time:
+                self._amqp_properties.absolute_expiry_time = value
         elif isinstance(value, datetime.timedelta):
             self._amqp_header.time_to_live = value.seconds * 1000
         else:
             self._amqp_header.time_to_live = int(value) * 1000
 
+        if self._amqp_header.time_to_live and self._amqp_header.time_to_live != MAX_DURATION_VALUE:
+            self._amqp_properties.creation_time = int(time.mktime(utc_now().timetuple()))
+            self._amqp_properties.absolute_expiry_time = min(
+                MAX_ABSOLUTE_EXPIRY_TIME,
+                self._amqp_properties.creation_time + self._amqp_header.time_to_live
+            )
+
     @property
     def scheduled_enqueue_time_utc(self):
         # type: () -> Optional[datetime.datetime]

sdk/servicebus/azure-servicebus/tests/test_queues.py

@@ -1263,6 +1263,7 @@ def message_content():
                     message.to = 'to'
                     message.reply_to = 'reply_to'
                     message.time_to_live = timedelta(seconds=60)
+                    assert message._amqp_properties.absolute_expiry_time == message._amqp_properties.creation_time + message._amqp_header.time_to_live
 
                     yield message