Skip to content

Commit 167328a

Browse files
authored
[Storage]Revert equal sign in async (#13501)
1 parent d006fbc commit 167328a

File tree

6 files changed

+4
-134
lines changed

6 files changed

+4
-134
lines changed

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/authentication.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
7979
uri_path = urlparse(request.http_request.url).path
8080
try:
8181
if isinstance(request.context.transport, AioHttpTransport) or \
82-
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
83-
isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
84-
AioHttpTransport):
82+
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
8583
uri_path = URL(uri_path)
8684
return '/' + self.account_name + str(uri_path)
8785
except TypeError:

sdk/storage/azure-storage-blob/tests/recordings/test_common_blob_async.test_create_blob_with_equal_sign.yaml

Lines changed: 0 additions & 104 deletions
This file was deleted.

sdk/storage/azure-storage-blob/tests/test_common_blob_async.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -272,24 +272,6 @@ async def test_create_blob_with_question_mark(self, resource_group, location, st
272272
content = data.decode('utf-8')
273273
self.assertEqual(content, blob_data)
274274

275-
@GlobalStorageAccountPreparer()
276-
@AsyncStorageTestCase.await_prepared_test
277-
async def test_create_blob_with_equal_sign(self, resource_group, location, storage_account, storage_account_key):
278-
# Arrange
279-
await self._setup(storage_account, storage_account_key)
280-
blob_name = '=ques=tion!'
281-
blob_data = u'???'
282-
283-
# Act
284-
blob = self.bsc.get_blob_client(self.container_name, blob_name)
285-
await blob.upload_blob(blob_data)
286-
287-
# Assert
288-
stream = await blob.download_blob()
289-
data = await stream.readall()
290-
self.assertIsNotNone(data)
291-
content = data.decode('utf-8')
292-
self.assertEqual(content, blob_data)
293275

294276
@GlobalStorageAccountPreparer()
295277
@AsyncStorageTestCase.await_prepared_test

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/authentication.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
7979
uri_path = urlparse(request.http_request.url).path
8080
try:
8181
if isinstance(request.context.transport, AioHttpTransport) or \
82-
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
83-
isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
84-
AioHttpTransport):
82+
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
8583
uri_path = URL(uri_path)
8684
return '/' + self.account_name + str(uri_path)
8785
except TypeError:

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/authentication.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
7979
uri_path = urlparse(request.http_request.url).path
8080
try:
8181
if isinstance(request.context.transport, AioHttpTransport) or \
82-
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
83-
isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
84-
AioHttpTransport):
82+
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
8583
uri_path = URL(uri_path)
8684
return '/' + self.account_name + str(uri_path)
8785
except TypeError:

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/authentication.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ def _get_canonicalized_resource(self, request):
7979
uri_path = urlparse(request.http_request.url).path
8080
try:
8181
if isinstance(request.context.transport, AioHttpTransport) or \
82-
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport) or \
83-
isinstance(getattr(getattr(request.context.transport, "_transport", None), "_transport", None),
84-
AioHttpTransport):
82+
isinstance(getattr(request.context.transport, "_transport", None), AioHttpTransport):
8583
uri_path = URL(uri_path)
8684
return '/' + self.account_name + str(uri_path)
8785
except TypeError:

0 commit comments

Comments
 (0)