Skip to content

Commit 33b03e6

Browse files
removed try/except wrapper on upsert method, added _process_table_error instead of create call (#13815)
fixes #13678
1 parent ce22a3f commit 33b03e6

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

sdk/tables/azure-data-tables/azure/data/tables/_table_client.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,6 @@ def upsert_entity( # pylint:disable=R1710
532532
partition_key = entity['PartitionKey']
533533
row_key = entity['RowKey']
534534
entity = _add_entity_properties(entity)
535-
536535
try:
537536
metadata = None
538537
if mode is UpdateMode.MERGE:
@@ -556,10 +555,5 @@ def upsert_entity( # pylint:disable=R1710
556555
raise ValueError("""Update mode {} is not supported.
557556
For a list of supported modes see the UpdateMode enum""".format(mode))
558557
return _trim_service_metadata(metadata)
559-
except ResourceNotFoundError:
560-
return self.create_entity(
561-
partition_key=partition_key,
562-
row_key=row_key,
563-
table_entity_properties=entity,
564-
**kwargs
565-
)
558+
except HttpResponseError as error:
559+
_process_table_error(error)

sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -567,10 +567,5 @@ async def upsert_entity(
567567
raise ValueError("""Update mode {} is not supported.
568568
For a list of supported modes see the UpdateMode enum""".format(mode))
569569
return _trim_service_metadata(metadata)
570-
except ResourceNotFoundError:
571-
return await self.create_entity(
572-
partition_key=partition_key,
573-
row_key=row_key,
574-
table_entity_properties=entity,
575-
**kwargs
576-
)
570+
except HttpResponseError as error:
571+
_process_table_error(error)

0 commit comments

Comments
 (0)