Skip to content

Commit 379ae6e

Browse files
authored
[Storage][Bug]request fail when metadata has trailing space (#11677)
1 parent 63497ae commit 379ae6e

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

sdk/storage/azure-storage-blob/azure/storage/blob/_shared/request_handlers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,5 @@ def add_metadata_headers(metadata=None):
143143
headers = {}
144144
if metadata:
145145
for key, value in metadata.items():
146-
headers['x-ms-meta-{}'.format(key)] = value
146+
headers['x-ms-meta-{}'.format(key.strip())] = value.strip() if value else value
147147
return headers

sdk/storage/azure-storage-blob/tests/test_common_blob.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ def test_set_blob_metadata_with_upper_case(self, resource_group, location, stora
587587
# bug in devtools...converts upper case header to lowercase
588588
# passes live.
589589
self._setup(storage_account, storage_account_key)
590-
metadata = {'hello': 'world', 'number': '42', 'UP': 'UPval'}
590+
metadata = {'hello': ' world ', ' number ': '42', 'UP': 'UPval'}
591591
blob_name = self._create_block_blob()
592592

593593
# Act

sdk/storage/azure-storage-blob/tests/test_common_blob_async.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ async def test_set_blob_metadata_with_upper_case(self, resource_group, location,
692692
# passes live.
693693
# Arrange
694694
await self._setup(storage_account, storage_account_key)
695-
metadata = {'hello': 'world', 'number': '42', 'UP': 'UPval'}
695+
metadata = {'hello': ' world ', ' number ': '42', 'UP': 'UPval'}
696696
blob_name = await self._create_block_blob()
697697

698698
# Act

sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/request_handlers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,5 @@ def add_metadata_headers(metadata=None):
143143
headers = {}
144144
if metadata:
145145
for key, value in metadata.items():
146-
headers['x-ms-meta-{}'.format(key)] = value
146+
headers['x-ms-meta-{}'.format(key.strip())] = value.strip() if value else value
147147
return headers

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/request_handlers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,5 @@ def add_metadata_headers(metadata=None):
143143
headers = {}
144144
if metadata:
145145
for key, value in metadata.items():
146-
headers['x-ms-meta-{}'.format(key)] = value
146+
headers['x-ms-meta-{}'.format(key.strip())] = value.strip() if value else value
147147
return headers

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/request_handlers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,5 @@ def add_metadata_headers(metadata=None):
143143
headers = {}
144144
if metadata:
145145
for key, value in metadata.items():
146-
headers['x-ms-meta-{}'.format(key)] = value
146+
headers['x-ms-meta-{}'.format(key.strip())] = value.strip() if value else value
147147
return headers

0 commit comments

Comments
 (0)