Use default ssl context (#32540)

* Use default ssl context

* update

* update

* update

* add test

* update

* update

* Update sdk/core/azure-core/azure/core/pipeline/transport/_aiohttp.py

* update release date

* update

* update

* update

Author: xiangyan99

sdk/core/azure-core/CHANGELOG.md

@@ -1,17 +1,15 @@
 # Release History
 
-## 1.29.5 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
+## 1.29.5 (2023-10-19)
 
 ### Bugs Fixed
 
 - Fixed an issue with `multipart/form-data` in the async transport where `data` was not getting encoded into the request body. #32473
 
 ### Other Changes
 
+- Use ssl context from aiohttp by default.
+
 ## 1.29.4 (2023-09-07)
 
 ### Bugs Fixed

sdk/core/azure-core/azure/core/pipeline/transport/_aiohttp.py

@@ -25,7 +25,16 @@
 # --------------------------------------------------------------------------
 from __future__ import annotations
 import sys
-from typing import Any, Optional, AsyncIterator as AsyncIteratorType, TYPE_CHECKING, overload, cast, Union, Type
+from typing import (
+    Any,
+    Optional,
+    AsyncIterator as AsyncIteratorType,
+    TYPE_CHECKING,
+    overload,
+    cast,
+    Union,
+    Type,
+)
 from types import TracebackType
 from collections.abc import AsyncIterator
 
@@ -86,7 +95,12 @@ class AioHttpTransport(AsyncHttpTransport):
     """
 
     def __init__(
-        self, *, session: Optional[aiohttp.ClientSession] = None, loop=None, session_owner: bool = True, **kwargs
+        self,
+        *,
+        session: Optional[aiohttp.ClientSession] = None,
+        loop=None,
+        session_owner: bool = True,
+        **kwargs,
     ):
         if loop and sys.version_info >= (3, 10):
             raise ValueError("Starting with Python 3.10, asyncio doesn’t support loop as a parameter anymore")
@@ -246,10 +260,13 @@ async def send(
                     break
 
         response: Optional[Union[AsyncHttpResponse, RestAsyncHttpResponse]] = None
-        config["ssl"] = self._build_ssl_config(
+        ssl = self._build_ssl_config(
             cert=config.pop("connection_cert", self.connection_config.cert),
             verify=config.pop("connection_verify", self.connection_config.verify),
         )
+        # If ssl=True, we just use default ssl context from aiohttp
+        if ssl is not True:
+            config["ssl"] = ssl
         # If we know for sure there is not body, disable "auto content type"
         # Otherwise, aiohttp will send "application/octet-stream" even for empty POST request
         # and that break services like storage signature

sdk/core/azure-core/tests/async_tests/test_pipeline_async.py

@@ -42,6 +42,7 @@
     AsyncioRequestsTransport,
     TrioRequestsTransport,
     AioHttpTransport,
+    HttpRequest,
 )
 
 from azure.core.polling.async_base_polling import AsyncLROBasePolling
@@ -58,6 +59,12 @@
 from utils import HTTP_REQUESTS
 
 
+try:
+    from unittest.mock import AsyncMock, PropertyMock
+except ImportError:
+    pass
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize("http_request", HTTP_REQUESTS)
 async def test_sans_io_exception(http_request):
@@ -272,7 +279,10 @@ def send(*args):
     assert pos_boo > pos_retry
 
     client = AsyncPipelineClient(
-        base_url="test", config=config, per_call_policies=boo_policy, per_retry_policies=foo_policy
+        base_url="test",
+        config=config,
+        per_call_policies=boo_policy,
+        per_retry_policies=foo_policy,
     )
     policies = client._pipeline._impl_policies
     assert boo_policy in policies
@@ -284,7 +294,10 @@ def send(*args):
     assert pos_foo > pos_retry
 
     client = AsyncPipelineClient(
-        base_url="test", config=config, per_call_policies=[boo_policy], per_retry_policies=[foo_policy]
+        base_url="test",
+        config=config,
+        per_call_policies=[boo_policy],
+        per_retry_policies=[foo_policy],
     )
     policies = client._pipeline._impl_policies
     assert boo_policy in policies
@@ -311,13 +324,19 @@ def send(*args):
     assert foo_policy == actual_policies[2]
 
     client = AsyncPipelineClient(
-        base_url="test", policies=policies, per_call_policies=boo_policy, per_retry_policies=[foo_policy]
+        base_url="test",
+        policies=policies,
+        per_call_policies=boo_policy,
+        per_retry_policies=[foo_policy],
     )
     actual_policies = client._pipeline._impl_policies
     assert boo_policy == actual_policies[0]
     assert foo_policy == actual_policies[3]
     client = AsyncPipelineClient(
-        base_url="test", policies=policies, per_call_policies=[boo_policy], per_retry_policies=[foo_policy]
+        base_url="test",
+        policies=policies,
+        per_call_policies=[boo_policy],
+        per_retry_policies=[foo_policy],
     )
     actual_policies = client._pipeline._impl_policies
     assert boo_policy == actual_policies[0]
@@ -337,3 +356,32 @@ def test_no_cleanup_policy_when_redirect_policy_is_empty():
     for policy in policies:
         if isinstance(policy, SensitiveHeaderCleanupPolicy):
             assert False
+
+
+@pytest.mark.skipif(sys.version_info < (3, 8), reason="Python 3.7 does not support AsyncMock")
+@pytest.mark.asyncio
+async def test_default_ssl_context():
+    class MockAiohttpSession:
+        async def __aenter__(self):
+            pass
+
+        async def __aexit__(self, exc_type, exc_val, exc_tb):
+            pass
+
+        async def close(self):
+            pass
+
+        async def open(self):
+            pass
+
+        async def request(self, method: str, url: str, **kwargs):
+            assert "ssl" not in kwargs
+            mock_response = AsyncMock(spec=aiohttp.ClientResponse)
+            type(mock_response).status = PropertyMock(return_value=200)
+            return mock_response
+
+    transport = AioHttpTransport(session=MockAiohttpSession(), session_owner=False)
+    pipeline = AsyncPipeline(transport=transport)
+
+    req = HttpRequest("GET", "https://bing.com")
+    await pipeline.run(req)