Skip to content

Commit 80e5e73

Browse files
authored
Remove VM Resource Detector until bug is fixed. (#33305)
* Remove VM Resource Detector until fix * changelog * Feedback
1 parent d19f8f9 commit 80e5e73

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
### Bugs Fixed
1010

11+
- Remove VM Resource Detector for hotfix
12+
([#33305](https://github.com/Azure/azure-sdk-for-python/pull/33305))
13+
1114
### Other Changes
1215

1316
## 1.1.0 (2023-11-08)

sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py

-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252

5353
_SUPPORTED_RESOURCE_DETECTORS = (
5454
"azure_app_service",
55-
"azure_vm",
5655
)
5756

5857
_logger = getLogger(__name__)

sdk/monitor/azure-monitor-opentelemetry/tests/configuration/test_configure.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,17 @@ def test_setup_resources(self):
199199
_setup_resources()
200200
self.assertEqual(
201201
os.environ["OTEL_EXPERIMENTAL_RESOURCE_DETECTORS"],
202-
"azure_app_service,azure_vm"
202+
# TODO: Change back to "azure_app_service,azure_vm" after VM Resource Detector fix for https://github.com/Azure/azure-sdk-for-python/issues/33295
203+
"azure_app_service"
203204
)
204205

205206
@patch.dict("os.environ", {"OTEL_EXPERIMENTAL_RESOURCE_DETECTORS": "test_detector"})
206207
def test_setup_resources_existing_detectors(self):
207208
_setup_resources()
208209
self.assertEqual(
209210
os.environ["OTEL_EXPERIMENTAL_RESOURCE_DETECTORS"],
210-
"test_detector,azure_app_service,azure_vm"
211+
# TODO: Change back to "azure_app_service,azure_vm" after VM Resource Detector fix for https://github.com/Azure/azure-sdk-for-python/issues/33295
212+
"test_detector,azure_app_service"
211213
)
212214

213215
@patch(

0 commit comments

Comments
 (0)