Remove implicit dependency on successful completion of verify-links (#18277)

* ensure that dev_reqs are installed before verify sdist. put verify-links back where it was. change conditions to always analyze deps

Author: scbedd

eng/pipelines/templates/steps/analyze.yml

@@ -32,11 +32,19 @@ steps:
     # target is based on data available per-package the --always-succeed should
     # be removed so this script can help enforce correct practices
     # (https://github.com/Azure/azure-sdk-for-python/issues/8697)
+
+
+  - pwsh: |
+     pip install -r eng/ci_tools.txt $(if($IsWindows) {"--user" })
+    displayName: 'Install Necessary Dependencies'
+    condition: succeededOrFailed()
+
   - script: |
       cd eng/versioning
       pip install -r requirements.txt
       python find_invalid_versions.py --always-succeed --service=${{parameters.ServiceDirectory}}
     displayName: Find Invalid Versions
+    condition: succeededOrFailed()
 
   - pwsh: |
       Get-ChildItem $(Build.SourcesDirectory) -Filter "*.py" |

eng/pipelines/templates/steps/analyze_dependency.yml

@@ -1,21 +1,25 @@
 steps:
   - task: UsePythonVersion@0
     displayName: 'Use Python $(PythonVersion)'
+    condition: succeededOrFailed()
     inputs:
      versionSpec: '$(PythonVersion)'
 
   - pwsh: |
      pip install -r eng/ci_tools.txt $(if($IsWindows) {"--user" })
      ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/eng/.docsettings.yml
     displayName: 'Verify Readmes'
+    condition: succeededOrFailed()
 
   - pwsh: |
       mkdir "$(Build.ArtifactStagingDirectory)/reports"
       Copy-Item -Path "$(Build.SourcesDirectory)/eng/common/InterdependencyGraph.html" -Destination "$(Build.ArtifactStagingDirectory)/reports/InterdependencyGraph.html"
     displayName: 'Populate Reports Staging Folder'
+    condition: succeededOrFailed()
 
   - task: PythonScript@0
     displayName: 'Analyze dependencies'
+    condition: succeededOrFailed()
     inputs:
      scriptPath: 'scripts/analyze_deps.py'
      arguments: '--verbose --out "$(Build.ArtifactStagingDirectory)/reports/dependencies.html" --dump "$(Build.ArtifactStagingDirectory)/reports/data.js"'