Skip to content

Commit f1de40a

Browse files
author
Rakshith Bhyravabhotla
authored
Increase dependency (#18500)
* Increase dependency * shared * update tests * test update * regression * version * Update sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py * Update sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py * Apply suggestions from code review
1 parent 9686966 commit f1de40a

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

sdk/core/azure-core-tracing-opencensus/tests/test_tracing_implementations.py

+1
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ def test_set_http_attributes(self):
141141
setattr(request, "headers", {})
142142
setattr(response, "status_code", 200)
143143
wrapped_class.set_http_attributes(request)
144+
assert wrapped_class.span_instance.span_kind == OpenCensusSpanKind.CLIENT
144145
assert wrapped_class.span_instance.attributes.get("http.method") == request.method
145146
assert wrapped_class.span_instance.attributes.get("component") == "http"
146147
assert wrapped_class.span_instance.attributes.get("http.url") == request.url

sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def test_add_attribute(self, tracer):
139139
assert parent.attributes["test"] == "test2"
140140

141141
def test_set_http_attributes(self, tracer):
142-
with tracer.start_as_current_span("Root") as parent:
142+
with tracer.start_as_current_span("Root", kind=OpenTelemetrySpanKind.CLIENT) as parent:
143143
wrapped_class = OpenTelemetrySpan(span=parent)
144144
request = mock.Mock()
145145
setattr(request, "method", "GET")
@@ -148,6 +148,7 @@ def test_set_http_attributes(self, tracer):
148148
setattr(request, "headers", {})
149149
setattr(response, "status_code", 200)
150150
wrapped_class.set_http_attributes(request)
151+
assert wrapped_class.span_instance.kind == OpenTelemetrySpanKind.CLIENT
151152
assert wrapped_class.span_instance.attributes.get("http.method") == request.method
152153
assert wrapped_class.span_instance.attributes.get("component") == "http"
153154
assert wrapped_class.span_instance.attributes.get("http.url") == request.url

sdk/core/azure-core/azure/core/tracing/_abstract_span.py

+1
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ def set_http_attributes(self, request, response=None):
221221
:param response: The response received by the server. Is None if no response received.
222222
:type response: ~azure.core.pipeline.transport.HttpResponse or ~azure.core.pipeline.transport.AsyncHttpResponse
223223
"""
224+
self.kind = SpanKind.CLIENT
224225
self.add_attribute(self._SPAN_COMPONENT, "http")
225226
self.add_attribute(self._HTTP_METHOD, request.method)
226227
self.add_attribute(self._HTTP_URL, request.url)

shared_requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -266,4 +266,4 @@ opentelemetry-sdk<2.0.0,>=1.0.0
266266
#override azure-mgmt-rdbms msrest>=0.6.21
267267
#override azure-mgmt-peering msrest>=0.6.21
268268
#override azure-mgmt-confidentialledger msrest>=0.6.21
269-
#override azure-mgmt-mixedreality msrest>=0.6.21
269+
#override azure-mgmt-mixedreality msrest>=0.6.21

0 commit comments

Comments
 (0)