diff --git a/.vscode/cspell.json b/.vscode/cspell.json index de43ddb8ebcb..ddd9c136b5fb 100644 --- a/.vscode/cspell.json +++ b/.vscode/cspell.json @@ -50,6 +50,7 @@ "sdk/communication/azure-communication-sms/**", "sdk/core/azure/**", "sdk/core/azure-common/**", + "sdk/core/azure-core-tracing-opencensus/**", "sdk/core/azure-core-tracing-opentelemetry/**", "sdk/core/azure-servicemanagement-legacy/**", "sdk/digitaltwins/azure-digitaltwins-core/**", @@ -458,6 +459,10 @@ "FHIR" ] }, + { + "filename": "sdk/core/azure-core-tracing-opentelemetry/**", + "words": ["ctxt", "somethingstuid"] + }, { "filename": "sdk/cognitivelanguage/azure-ai-language-conversations/**", "words": ["conv"], diff --git a/sdk/core/azure-core-tracing-opentelemetry/README.md b/sdk/core/azure-core-tracing-opentelemetry/README.md index 29db252e0c67..f063405ed1b9 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/README.md +++ b/sdk/core/azure-core-tracing-opentelemetry/README.md @@ -70,7 +70,7 @@ from azure.storage.blob import BlobServiceClient with tracer.start_as_current_span(name="MyApplication"): client = BlobServiceClient.from_connection_string('connectionstring') - client.create_container('mycontainer') # Call will be traced + client.create_container('my_container') # Call will be traced ``` Azure Exporter can be found in the [package](https://pypi.org/project/opentelemetry-azure-monitor-exporter/) `opentelemetry-azure-monitor-exporter` diff --git a/sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py b/sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py index f3a1bfe6c350..f872222877ce 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py +++ b/sdk/core/azure-core-tracing-opentelemetry/azure/core/tracing/ext/opentelemetry_span/__init__.py @@ -140,8 +140,8 @@ def kind(self, value): self._span_instance._kind = kind # pylint: disable=protected-access except AttributeError: warnings.warn( - """Kind must be set while creating the span for Opentelemetry. It might be possible - that one of the packages you are using doesn't follow the latest Opentelemtry Spec. + """Kind must be set while creating the span for OpenTelemetry. It might be possible + that one of the packages you are using doesn't follow the latest Opentelemetry Spec. Try updating the azure packages to the latest versions.""" ) @@ -233,8 +233,8 @@ def link_from_headers(cls, headers, attributes=None): current_span._links.append(OpenTelemetryLink(span_ctx, attributes)) # pylint: disable=protected-access except AttributeError: warnings.warn( - """Link must be added while creating the span for Opentelemetry. It might be possible - that one of the packages you are using doesn't follow the latest Opentelemtry Spec. + """Link must be added while creating the span for OpenTelemetry. It might be possible + that one of the packages you are using doesn't follow the latest Opentelemetry Spec. Try updating the azure packages to the latest versions.""" ) diff --git a/sdk/core/azure-core-tracing-opentelemetry/samples/README.md b/sdk/core/azure-core-tracing-opentelemetry/samples/README.md index 617fe97bab32..003f6937186e 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/samples/README.md +++ b/sdk/core/azure-core-tracing-opentelemetry/samples/README.md @@ -7,9 +7,9 @@ products: urlFragment: azure-core-tracing-opentelemetry-samples --- -# Azure Core Tracing Opentelemetry Integration Python Samples +# Azure Core Tracing OpenTelemetry Integration Python Samples -These code samples show using the tracing opentelemetry integration with few services including servicebus, storage and eventgrid. A simple console span exporter is used in this example to export the calls. However, the code to use the azure monitor exporter has also been provided and commented in each sample. +These code samples show using the tracing OpenTelemetry integration with few services including servicebus, storage and eventgrid. A simple console span exporter is used in this example to export the calls. However, the code to use the azure monitor exporter has also been provided and commented in each sample. * Trace Storage Calls to create a container: [sample_storage.py][python-sample-storage] * Trace Eventgrid calls to publish an event : [sample_eventgrid.py][python-sample-eventgrid] @@ -24,7 +24,7 @@ It is assumed that the relevant SDKs are installed along with this extension. Be - [azure-servicebus](https://pypi.org/project/azure-servicebus) v7 or greater. - [azure-eventgrid](https://pypi.org/project/azure-eventgrid) v4 or greater. - [azure-eventhub](https://pypi.org/project/azure-eventhub/) v5 or greater -- [opentelemtry-sdk](https://pypi.org/project/opentelemetry-sdk/) +- [opentelemetry-sdk](https://pypi.org/project/opentelemetry-sdk/) [python-sample-storage]: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core-tracing-opentelemetry/samples/sample_storage.py [python-sample-eventgrid]: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventgrid.py diff --git a/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventhubs.py b/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventhubs.py index 02df7b568e0a..1130f0703013 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventhubs.py +++ b/sdk/core/azure-core-tracing-opentelemetry/samples/sample_eventhubs.py @@ -2,7 +2,7 @@ Examples to show usage of the azure-core-tracing-opentelemetry with the Eventhub SDK. -This example traces calls for senda batch to eventhub. +This example traces calls for sending a batch to eventhub. An alternative path to export using AzureMonitor is also mentioned in the sample. Please take a look at the commented code. diff --git a/sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_eh.py b/sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_eh.py index 12fe1085be55..8ace53558f24 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_eh.py +++ b/sdk/core/azure-core-tracing-opentelemetry/samples/sample_receive_eh.py @@ -2,7 +2,7 @@ Examples to show usage of the azure-core-tracing-opentelemetry with the Eventhub SDK. -This example traces calls for senda batch to eventhub. +This example traces calls for sending a batch to eventhub. An alternative path to export using AzureMonitor is also mentioned in the sample. Please take a look at the commented code. diff --git a/sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py b/sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py index a3be80465e09..769207087099 100644 --- a/sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py +++ b/sdk/core/azure-core-tracing-opentelemetry/tests/test_tracing_implementations.py @@ -188,4 +188,4 @@ def test_span_kind(self, tracer): assert wrapped_class.kind == SpanKind.INTERNAL with pytest.raises(ValueError): - wrapped_class.kind = "somethingstuid" + wrapped_class.kind = "somethingstuid" \ No newline at end of file