initial pr feedback

Author: analogrelay

sdk/typespec/typespec_client_core/src/http/format.rs

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
 use serde::de::DeserializeOwned;
 
 use crate::http::response::ResponseBody;
@@ -27,7 +30,7 @@ pub trait DeserializeWith<F: Format>: Sized {
 /// Implements [`DeserializeWith<T>`] for [`ResponseBody`], by simply returning the body stream as is.
 #[cfg_attr(target_arch = "wasm32", async_trait::async_trait(?Send))]
 #[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)]
-impl<T: Format> DeserializeWith<T> for ResponseBody {
+impl<F: Format> DeserializeWith<F> for ResponseBody {
     async fn deserialize_with(body: ResponseBody) -> typespec::Result<Self> {
         Ok(body)
     }

sdk/typespec/typespec_client_core/src/http/response.rs

@@ -28,7 +28,7 @@ pub struct Response<T = ResponseBody, F = DefaultFormat> {
     status: StatusCode,
     headers: Headers,
     body: ResponseBody,
-    phantom: PhantomData<(T, F)>,
+    _phantom: PhantomData<(T, F)>,
 }
 
 impl<F> Response<ResponseBody, F> {
@@ -40,7 +40,7 @@ impl<F> Response<ResponseBody, F> {
             status: self.status,
             headers: self.headers,
             body: self.body,
-            phantom: PhantomData,
+            _phantom: PhantomData,
         }
     }
 }
@@ -52,7 +52,7 @@ impl<T, F> Response<T, F> {
             status,
             headers,
             body: ResponseBody::new(stream),
-            phantom: PhantomData,
+            _phantom: PhantomData,
         }
     }
 
@@ -62,7 +62,7 @@ impl<T, F> Response<T, F> {
             status,
             headers,
             body: ResponseBody::from_bytes(bytes),
-            phantom: PhantomData,
+            _phantom: PhantomData,
         }
     }
 
@@ -97,7 +97,7 @@ impl<T, F> Response<T, F> {
             status: self.status,
             headers: self.headers,
             body: self.body,
-            phantom: PhantomData,
+            _phantom: PhantomData,
         }
     }
 }