Skip to content

Cosmos: Allow query engine to return Box<serde_json::value::RawValue> for items #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
analogrelay opened this issue May 16, 2025 · 0 comments · May be fixed by #2617
Open

Cosmos: Allow query engine to return Box<serde_json::value::RawValue> for items #2616

analogrelay opened this issue May 16, 2025 · 0 comments · May be fixed by #2617
Assignees
@analogrelay
Labels
Cosmos The azure_cosmos crate

Comments

@analogrelay
Copy link
Member

The Client Engine, that provides the implementation of the query engine functionality, currently returns items as Box<serde_json::value::RawValue>. We should change the API for the QueryPipeline trait to accept these as results, because they allow the client engine to hold un-parsed chunks of JSON and pass them back to the SDK to deserialize fully, without incurring extra copies or serialize/deserialize cycles.
@analogrelay analogrelay self-assigned this May 16, 2025
@analogrelay analogrelay added the Cosmos The azure_cosmos crate label May 16, 2025
analogrelay added a commit to analogrelay/azure-sdk-for-rust that referenced this issue May 16, 2025
@analogrelay
fix Azure#2616 by using RawValue, and fix query rewriting
e237068
@analogrelay analogrelay linked a pull request May 16, 2025 that will close this issue
Open
analogrelay added a commit to analogrelay/azure-sdk-for-rust that referenced this issue May 16, 2025
@analogrelay
fix Azure#2616 by using RawValue, and fix query rewriting
dfe2868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@analogrelay analogrelay

Labels
Cosmos The azure_cosmos crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cosmos: fix #2616 by using RawValue, and fix query rewriting analogrelay/azure-sdk-for-rust
1 participant
@analogrelay