Skip to content

Unnecessary fields for a particular option should not be added by cli at initialization #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aniruddh25 opened this issue Feb 2, 2023 · 5 comments
Assignees
Milestone

Comments

@Aniruddh25
Copy link
Contributor

Do you observe key-fields property (with empty array as the value) being added by CLI even if the source type is a stored procedure?
I think this should only be added if its view as mandated by the schema. Please create a bug if that's the case.

@Aniruddh25
Copy link
Contributor Author

Ensure the config created for cli is valid with respect to the json schema.

@severussundar
Copy link
Contributor

severussundar commented Feb 2, 2023

We are not seeing empty array for key-fields in case for stored procedures. The unit tests are updated to reflect this.

@Aniruddh25
Copy link
Contributor Author

How about other options - not only for this particular scenario. The issue is more about ensuring CLI generates a config that adheres to our own published schema

@abhishekkumams
Copy link
Contributor

I checked the below:

  1. created table without key-fields, key-fields was not present in config.
  2. created views without key-fields, key-fields was not present in config.
  3. converted table/view with key fields to Stored procedure, key-fields was not present in config.

I'll check if there are any other fields which are unnecessary but still show up in the config.

@abhishekkumams
Copy link
Contributor

Closing this issue, as it has been verified that this issue is no longer happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants