Skip to content

systemErrorRetryPolicy doesn't do anything #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ejizba opened this issue Jan 27, 2021 · 4 comments
Closed

systemErrorRetryPolicy doesn't do anything #412

ejizba opened this issue Jan 27, 2021 · 4 comments
Labels

Comments

@ejizba
Copy link

ejizba commented Jan 27, 2021

I noticed the "ms-rest-js" package has the same exact problem the "core-http" package had as described here:

Azure/azure-sdk-for-js#8803
Azure/azure-sdk-for-js#8459

Since it doesn't use catch and pass an error along here, it doesn't do anything.

I'm not super familiar with the differences between "ms-rest-js" and "core-http" - any idea why they have duplicate code in the first place?

@jeremymeng jeremymeng added the bug label Jan 27, 2021
@jeremymeng
Copy link
Member

I'm not super familiar with the differences between "ms-rest-js" and "core-http" - any idea why they have duplicate code in the first place?

Here's some context https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-https/documentation/core2.md#history-context-and-motivations

We should port the fix Azure/azure-sdk-for-js#8803 here.

@ejizba
Copy link
Author

ejizba commented Jan 28, 2021

@jeremymeng any idea when we can get an updated package with this fix? This has been a thorn in our side for a while and it's a pretty wide-ranging problem for us. I work on Azure extensions for VS Code, and it seems like pretty much every @azure/arm-* package we use relies on "ms-rest-js", not "core-http"

@jeremymeng
Copy link
Member

@ejizba I will work on porting the fix today, and hopefully have a release soon.

@jeremymeng
Copy link
Member

Closing, fixed by #413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants