fixed unit tests failing

Author: lalimasharda

lib/msal-angular/karma.conf.js

@@ -18,7 +18,8 @@ module.exports = function (config) {
             jasmine: {
                 failSpecWithNoExpectations: true
             },
-            clearContext: false // leave Jasmine Spec Runner output visible in browser
+            clearContext: false, // leave Jasmine Spec Runner output visible in browser
+            captureConsole: true // turns on console logging for test debugging
         },
         coverageIstanbulReporter: {
             dir: require("path").join(__dirname, "./coverage"),

lib/msal-angular/src/msal.broadcast.service.spec.ts

@@ -40,6 +40,7 @@ function initializeMsal(providers: any[] = []) {
       }),
     ],
     providers: [MsalBroadcastService, ...providers],
+    teardown: { destroyAfterEach: false },
   });
   broadcastService = TestBed.inject(MsalBroadcastService);
 }

lib/msal-angular/src/msal.guard.spec.ts

@@ -68,6 +68,7 @@ function initializeMsal(providers: any[] = []) {
       RouterTestingModule.withRoutes([]),
     ],
     providers: [MsalGuard, MsalService, MsalBroadcastService, ...providers],
+    teardown: { destroyAfterEach: false },
   });
 
   authService = TestBed.inject(MsalService);

lib/msal-angular/src/msal.interceptor.spec.ts

@@ -124,6 +124,7 @@ function initializeMsal() {
       },
       Location,
     ],
+    teardown: { destroyAfterEach: false },
   });
 
   interceptor = TestBed.inject(MsalInterceptor);

lib/msal-angular/src/msal.navigation.client.spec.ts

@@ -44,6 +44,7 @@ describe("MsalCustomNaviationClient", () => {
         MsalService,
         MsalGuard,
       ],
+      teardown: { destroyAfterEach: false },
     });
     authService = TestBed.inject(MsalService);
     navigationClient = TestBed.inject(MsalCustomNavigationClient);

lib/msal-angular/src/msal.redirect.component.spec.ts

@@ -27,6 +27,7 @@ function initializeMsal() {
     declarations: [MsalRedirectComponent],
     imports: [MsalModule.forRoot(MSALInstanceFactory(), null, null)],
     providers: [],
+    teardown: { destroyAfterEach: false },
   });
 
   authService = TestBed.inject(MsalService);

lib/msal-angular/src/msal.service.spec.ts

@@ -30,6 +30,7 @@ function initializeMsal() {
       }),
     ],
     providers: [MsalService, MsalBroadcastService],
+    teardown: { destroyAfterEach: false },
   });
 
   authService = TestBed.inject(MsalService);
@@ -198,7 +199,7 @@ describe("MsalService", () => {
 
       authService.ssoSilent(request).subscribe({
         error: (error: AuthError) => {
-          expect(error.message).toBe(sampleError.message);
+          expect(error.errorMessage).toBe(sampleError.errorMessage);
           expect(
             PublicClientApplication.prototype.ssoSilent
           ).toHaveBeenCalledWith(request);
@@ -259,7 +260,7 @@ describe("MsalService", () => {
 
       authService.acquireTokenSilent(request).subscribe({
         error: (error: AuthError) => {
-          expect(error.message).toBe(sampleError.message);
+          expect(error.errorMessage).toBe(sampleError.errorMessage);
           expect(
             PublicClientApplication.prototype.acquireTokenSilent
           ).toHaveBeenCalledWith(request);
@@ -339,7 +340,7 @@ describe("MsalService", () => {
 
       authService.acquireTokenPopup(request).subscribe({
         error: (error: AuthError) => {
-          expect(error.message).toBe(sampleError.message);
+          expect(error.errorMessage).toBe(sampleError.errorMessage);
           expect(
             PublicClientApplication.prototype.acquireTokenPopup
           ).toHaveBeenCalledWith(request);

lib/msal-angular/src/msal.service.ts

@@ -16,6 +16,7 @@ import {
   SsoSilentRequest,
   Logger,
   WrapperSKU,
+  AuthError,
 } from "@azure/msal-browser";
 import { Observable, from } from "rxjs";
 import { IMsalService } from "./IMsalService";
@@ -61,11 +62,8 @@ export class MsalService implements IMsalService {
         .then(() =>
           this.instance.handleRedirectPromise(hash || this.redirectHash)
         )
-        .catch((error) => {
-          this.logger.error(
-            "Error while executing handleRedirectPromise",
-            error
-          );
+        .catch((error: AuthError) => {
+          this.logger.error("Error while executing handleRedirectPromise");
           throw error; // Rethrow the error to ensure the return type matches
         })
         .finally(() => {