Skip to content

Commit 13d730b

Browse files
committed
Update authority link, add timeout to angular9 e2e tests
1 parent dc10cf2 commit 13d730b

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

samples/e2eTestUtils/BrowserCacheTestUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import puppeteer from "puppeteer";
1+
import * as puppeteer from "puppeteer";
22

33
import { LabConfig } from "./LabConfig";
44
import { Configuration } from "../../lib/msal-browser";

samples/msal-angular-v2-samples/angular10-sample-app/src/app/app.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function MSALInstanceFactory(): IPublicClientApplication {
2727
auth: {
2828
// clientId: '6226576d-37e9-49eb-b201-ec1eeb0029b6', // Prod enviroment. Uncomment to use.
2929
clientId: '3fba556e-5d4a-48e3-8e1a-fd57c12cb82e', // PPE testing environment
30-
// authority: "https://login.windows-ppe.net/common", // Prod environment. Uncomment to use.
30+
// authority: 'https://login.microsoftonline.com/common', // Prod environment. Uncomment to use.
3131
authority: 'https://login.windows-ppe.net/common', // PPE testing environment.
3232
redirectUri: '/',
3333
postLogoutRedirectUri: '/'

samples/msal-angular-v2-samples/angular11-sample-app/src/app/app.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function MSALInstanceFactory(): IPublicClientApplication {
2828
auth: {
2929
// clientId: '6226576d-37e9-49eb-b201-ec1eeb0029b6', // Prod enviroment. Uncomment to use.
3030
clientId: '3fba556e-5d4a-48e3-8e1a-fd57c12cb82e', // PPE testing environment
31-
// authority: "https://login.windows-ppe.net/common", // Prod environment. Uncomment to use.
31+
// authority: 'https://login.microsoftonline.com/common', // Prod environment. Uncomment to use.
3232
authority: 'https://login.windows-ppe.net/common', // PPE testing environment.
3333
redirectUri: '/',
3434
postLogoutRedirectUri: '/'

samples/msal-angular-v2-samples/angular9-v2-sample-app/src/app/app.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function MSALInstanceFactory(): IPublicClientApplication {
2828
auth: {
2929
// clientId: '6226576d-37e9-49eb-b201-ec1eeb0029b6', // Prod enviroment. Uncomment to use.
3030
clientId: '3fba556e-5d4a-48e3-8e1a-fd57c12cb82e', // PPE testing environment
31-
// authority: "https://login.windows-ppe.net/common", // Prod environment. Uncomment to use.
31+
// authority: 'https://login.microsoftonline.com/common', // Prod environment. Uncomment to use.
3232
authority: 'https://login.windows-ppe.net/common', // PPE testing environment.
3333
redirectUri: '/',
3434
postLogoutRedirectUri: '/'

samples/msal-angular-v2-samples/angular9-v2-sample-app/test/home.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ describe('/ (Home Page)', () => {
6464
// Initiate Login
6565
const [signInButton] = await page.$x("//button[contains(., 'Login')]");
6666
await signInButton.click();
67+
await page.waitForTimeout(50);
6768
await screenshot.takeScreenshot(page, "Login button clicked");
6869
const [loginRedirectButton] = await page.$x("//button[contains(., 'Login using Redirect')]");
6970
await loginRedirectButton.click();
@@ -101,6 +102,7 @@ describe('/ (Home Page)', () => {
101102
// Initiate Login
102103
const [signInButton] = await page.$x("//button[contains(., 'Login')]");
103104
await signInButton.click();
105+
await page.waitForTimeout(50);
104106
await screenshot.takeScreenshot(page, "Login button clicked");
105107
const [loginPopupButton] = await page.$x("//button[contains(., 'Login using Popup')]");
106108
const newPopupWindowPromise = new Promise<puppeteer.Page>(resolve => page.once("popup", resolve));

0 commit comments

Comments
 (0)