updated code as per feedback

Author: rohitnarula7176

.gitignore

@@ -255,5 +255,4 @@ paket-files/
 lib/*.js
 lib/*.js.map
 #tests/unit/*.js # TODO add these once the unit tests are in TS
-#tests/unit/*.js.map
-out
+#tests/unit/*.js.map

lib/AccessTokenCacheItem.ts

@@ -8,3 +8,4 @@ namespace MSAL {
         }
     }
 }
+

lib/AccessTokenKey.ts

@@ -2,14 +2,14 @@ namespace MSAL {
     export class AccessTokenKey {
         authority: string;
         clientId: string;
-        homeObjectId: string;
+        userIdentifier: string;
         Scopes: string;
 
-        constructor(authority: string, clientId: string, scopes: string, homeObjectId: string) {
+        constructor(authority: string, clientId: string, scopes: string, userIdentifier: string) {
             this.authority = authority;
             this.clientId = clientId;
             this.Scopes = scopes;
-            this.homeObjectId = homeObjectId;
+            this.userIdentifier = userIdentifier;
         }
     }
 }

lib/AuthenticationRequestParameters.ts

@@ -28,34 +28,37 @@ namespace MSAL {
             this.responseType = responseType;
             this.redirectUri = redirectUri;
             // randomly generated values
-            if (responseType !== "token")
-                this.nonce = Utils.Guid();
-            this.correlationId = Utils.Guid();
-            this.state = Utils.Guid();
-            this.nonce = Utils.Guid();
+            if (responseType !== "token") {
+                this.nonce = Utils.CreateNewGuid();
+            }
+            this.correlationId = Utils.CreateNewGuid();
+            this.state = Utils.CreateNewGuid();
+            this.nonce = Utils.CreateNewGuid();
             // telemetry information
             this.xClientSku = "Js";
             this.xClientVer = Utils.GetLibraryVersion();
         }
 
         CreateNavigateUrl(scopes: Array<string>): string {
-            if (!scopes)
+            if (!scopes) {
                 scopes = [this.clientId];
+            }
             let requestUrl = "";
             let str: Array<string> = [];
             str.push('?response_type=' + this.responseType);
             if (this.responseType === ResponseTypes[ResponseTypes.id_token]) {
-                if (scopes.indexOf(this.clientId) > -1)
+                if (scopes.indexOf(this.clientId) > -1) {
                     this.translateclientIdUsedInScope(scopes);
+                }
             }
-
             str.push('scope=' + encodeURIComponent(this.parseScope(scopes)));
             str.push('client_id=' + encodeURIComponent(this.clientId));
             str.push('redirect_uri=' + encodeURIComponent(this.redirectUri));
             str.push('state=' + encodeURIComponent(this.state));
             str.push('nonce=' + encodeURIComponent(this.nonce));
-            if (this.extraQueryParameters)
+            if (this.extraQueryParameters) {
                 str.push(this.extraQueryParameters);
+            }
             str.push('client-request-id=' + encodeURIComponent(this.correlationId));
             requestUrl = this.authority + '/oauth2/v2.0/authorize' + str.join('&') + "&x-client-SKU=" + this.xClientSku + "&x-client-Ver=" + this.xClientVer;
             return requestUrl;

lib/Logger.ts

@@ -1,7 +1,7 @@
 namespace MSAL {
 
     export interface ILoggerCallback {
-        (level: LogLevel, message: string,containsPii:boolean): boolean;
+        (level: LogLevel, message: string,containsPii:boolean): void;
     }
 
     export enum LogLevel {
@@ -15,11 +15,15 @@ namespace MSAL {
         private static _instance: Logger;
         private _correlationId: string;
         get correlationId(): string { return this._correlationId; }
+        set correlationId(correlationId: string) {
+            this._correlationId = correlationId;
+        };
         private _level: LogLevel = LogLevel.Info;
         get level(): LogLevel { return this._level; }
         set level(logLevel: LogLevel) {
-            if (LogLevel[logLevel])
+            if (LogLevel[logLevel]) {
                 this._level = logLevel;
+            }
             else throw new Error("Provide a valid value for level. Possibles range for logLevel is 0-3");
         };
 
@@ -32,6 +36,9 @@ namespace MSAL {
         private _localCallback: ILoggerCallback;
         get localCallback(): ILoggerCallback { return this._localCallback; }
         set localCallback(localCallback: ILoggerCallback) {
+            if (this.localCallback) {
+                throw new Error("MSAL logging callback can only be set once per process and should never change once set.");
+            }
             this._localCallback = localCallback;
         };
 
@@ -49,18 +56,19 @@ namespace MSAL {
             }
             var timestamp = new Date().toUTCString();
             var log: string = '';
-            if (!Utils.isEmpty(this.correlationId))
+            if (!Utils.isEmpty(this.correlationId)) {
                 log = timestamp + ':' + this._correlationId + '-' + Utils.GetLibraryVersion() + '-' + LogLevel[logLevel] + ' ' + logMessage;
-            else
+            }
+            else {
                 log = timestamp + ':' + Utils.GetLibraryVersion() + '-' + LogLevel[logLevel] + ' ' + logMessage;
-
+            }
             this.executeCallback(logLevel, log, containsPii);
-
         }
 
         executeCallback(level: LogLevel, message: string, containsPii: boolean) {
-            if (this.localCallback)
+            if (this.localCallback) {
                 this.localCallback(level, message, containsPii);
+            }
         }
 
         error(message: string): void {
@@ -94,7 +102,5 @@ namespace MSAL {
         verbosePii(message: string): void {
             this.LogMessage(message, LogLevel.Verbose, true);
         }
-       
     }
-
 }

lib/RequestContext.ts

@@ -10,6 +10,7 @@ namespace MSAL {// Singleton Class
             if (RequestContext._instance) {
                 return RequestContext._instance;
             }
+
             this._logger = new Logger(correlationId);
             this._correlationId = this._logger.correlationId;
             RequestContext._instance = this;

lib/User.ts

@@ -0,0 +1,6 @@
+namespace MSAL {
+    export interface User {
+        username: string;
+        profile: any;
+    }
+}