updating with feedback from PR

Author: pkanher617

lib/msal-browser/src/app/PublicClientApplication.ts

@@ -575,9 +575,7 @@ export class PublicClientApplication {
      */
     public getAccountByUsername(userName: string): IAccount {
         const allAccounts = this.getAllAccounts();
-        return allAccounts.filter((accountObj) => {
-            return accountObj.username === userName;
-        })[0];
+        return allAccounts.filter(accountObj => accountObj.username === userName)[0];
     }
 
     // #endregion

samples/VanillaJSTestApp2.0/app/default/auth.js

@@ -40,11 +40,11 @@ function handleResponse(resp) {
 async function signIn(method) {
     signInType = isIE ? "loginRedirect" : method;
     if (signInType === "loginPopup") {
-        myMSALObj.loginPopup(loginRequest).then(handleResponse).catch(function (error) {
+        return myMSALObj.loginPopup(loginRequest).then(handleResponse).catch(function (error) {
             console.log(error);
         });
     } else if (signInType === "loginRedirect") {
-        myMSALObj.loginRedirect(loginRequest)
+        return myMSALObj.loginRedirect(loginRequest)
     }
 }