Skip to content

Commit eef0616

Browse files
committed
Merge branch 'dev' into browser-beta-2-release
2 parents 0c0876f + 2f9362f commit eef0616

File tree

13 files changed

+126
-321
lines changed

13 files changed

+126
-321
lines changed

lib/msal-angular/package-lock.json

Lines changed: 0 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/msal-angularjs/package-lock.json

Lines changed: 21 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/msal-browser/test/config/Configuration.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ describe("Configuration.ts Class Unit Tests", () => {
4848
expect(emptyConfig.system.networkClient).to.be.not.null.and.not.undefined;
4949
expect(emptyConfig.system.windowHashTimeout).to.be.not.null.and.not.undefined;
5050
expect(emptyConfig.system.windowHashTimeout).to.be.eq(DEFAULT_POPUP_TIMEOUT_MS);
51-
expect(emptyConfig.system.tokenRenewalOffsetSeconds).to.be.undefined;
52-
expect(emptyConfig.system.telemetry).to.be.undefined;
51+
expect(emptyConfig.system.tokenRenewalOffsetSeconds).to.be.eq(300);
52+
expect(emptyConfig.system.telemetry).to.be.null;
5353
});
5454

5555
it("Tests default logger", () => {

lib/msal-common/src/client/SPAClient.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -213,13 +213,7 @@ export class SPAClient extends BaseClient {
213213
// Get current cached tokens
214214
const cachedTokenItem = this.getCachedTokens(requestScopes, acquireTokenAuthority.canonicalAuthority, request.resource, account && account.homeAccountIdentifier);
215215
const expirationSec = Number(cachedTokenItem.value.expiresOnSec);
216-
console.log(TimeUtils.nowSeconds());
217-
console.log(this.config.systemOptions.tokenRenewalOffsetSeconds);
218216
const offsetCurrentTimeSec = TimeUtils.nowSeconds() + this.config.systemOptions.tokenRenewalOffsetSeconds;
219-
// console.log(cachedTokenItem);
220-
// console.log(expirationSec);
221-
console.log(offsetCurrentTimeSec);
222-
// console.log(expirationSec > offsetCurrentTimeSec);
223217
// Check if refresh is forced, or if tokens are expired. If neither are true, return a token response with the found token entry.
224218
if (!request.forceRefresh && expirationSec && expirationSec > offsetCurrentTimeSec) {
225219
const cachedScopes = ScopeSet.fromString(cachedTokenItem.key.scopes, this.config.authOptions.clientId, true);
@@ -358,16 +352,12 @@ export class SPAClient extends BaseClient {
358352
if (tokenCacheItems.length === 0) {
359353
throw ClientAuthError.createNoTokensFoundError(requestScopes.printScopes());
360354
}
361-
console.log("All matching tokens");
362-
console.log(tokenCacheItems);
363355

364356
// Filter cache items based on available scopes.
365357
const filteredCacheItems: Array<AccessTokenCacheItem> = tokenCacheItems.filter(cacheItem => {
366358
const cachedScopes = ScopeSet.fromString(cacheItem.key.scopes, this.config.authOptions.clientId, true);
367359
return cachedScopes.containsScopeSet(requestScopes);
368360
});
369-
console.log("Filtering");
370-
console.log(filteredCacheItems);
371361

372362
// If cache items contains too many matching tokens, throw error.
373363
if (filteredCacheItems.length > 1) {

lib/msal-common/test/config/Configuration.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { version } from "../../package.json";
99
import {TEST_CONFIG} from "../utils/StringConstants";
1010

1111

12-
describe("Configuration.ts Class Unit Tests", () => {
12+
describe("ClientConfiguration.ts Class Unit Tests", () => {
1313

1414
it("buildConfiguration assigns default functions", async () => {
1515
const emptyConfig: ClientConfiguration = buildClientConfiguration({});

lib/msal-core/package-lock.json

Lines changed: 17 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)