Merge pull request #684 from ikicodedev/master

Fix error in readme example code

Author: mvanbeusekom

README.md

@@ -128,23 +128,22 @@ Future<Position> _determinePosition() async {
 
   permission = await Geolocator.checkPermission();
   if (permission == LocationPermission.denied) {
-      permission = await Geolocator.requestPermission();
-    if (permission == LocationPermission.deniedForever) {
-      // Permissions are denied forever, handle appropriately. 
-      return Future.error(
-        'Location permissions are permanently denied, we cannot request permissions.');
-    } 
-
+    permission = await Geolocator.requestPermission();
     if (permission == LocationPermission.denied) {
       // Permissions are denied, next time you could try
       // requesting permissions again (this is also where
       // Android's shouldShowRequestPermissionRationale 
       // returned true. According to Android guidelines
       // your App should show an explanatory UI now.
-      return Future.error(
-          'Location permissions are denied');
+      return Future.error('Location permissions are denied');
     }
   }
+  
+  if (permission == LocationPermission.deniedForever) {
+    // Permissions are denied forever, handle appropriately. 
+    return Future.error(
+      'Location permissions are permanently denied, we cannot request permissions.');
+  }
 
   // When we reach here, permissions are granted and we can
   // continue accessing the position of the device.

geolocator/README.md

@@ -128,23 +128,22 @@ Future<Position> _determinePosition() async {
 
   permission = await Geolocator.checkPermission();
   if (permission == LocationPermission.denied) {
-      permission = await Geolocator.requestPermission();
-    if (permission == LocationPermission.deniedForever) {
-      // Permissions are denied forever, handle appropriately. 
-      return Future.error(
-        'Location permissions are permanently denied, we cannot request permissions.');
-    } 
-
+    permission = await Geolocator.requestPermission();
     if (permission == LocationPermission.denied) {
       // Permissions are denied, next time you could try
       // requesting permissions again (this is also where
       // Android's shouldShowRequestPermissionRationale 
       // returned true. According to Android guidelines
       // your App should show an explanatory UI now.
-      return Future.error(
-          'Location permissions are denied');
+      return Future.error('Location permissions are denied');
     }
   }
+  
+  if (permission == LocationPermission.deniedForever) {
+    // Permissions are denied forever, handle appropriately. 
+    return Future.error(
+      'Location permissions are permanently denied, we cannot request permissions.');
+  } 
 
   // When we reach here, permissions are granted and we can
   // continue accessing the position of the device.