Skip to content

Commit f2bd9db

Browse files
author
Benoît Lévêque
committed
use a property for the messageId
1 parent 5736c26 commit f2bd9db

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

pkg/sqs/SqsMessage.php

+7-2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ class SqsMessage implements Message
5858
*/
5959
private $requeueVisibilityTimeout;
6060

61+
/**
62+
* @var string|null
63+
*/
64+
private $messageId;
65+
6166
public function __construct(string $body = '', array $properties = [], array $headers = [])
6267
{
6368
$this->body = $body;
@@ -166,12 +171,12 @@ public function getCorrelationId(): ?string
166171

167172
public function setMessageId(string $messageId = null): void
168173
{
169-
$this->setHeader('message_id', $messageId);
174+
$this->messageId = $messageId;
170175
}
171176

172177
public function getMessageId(): ?string
173178
{
174-
return $this->getHeader('message_id');
179+
return $this->messageId;
175180
}
176181

177182
public function getTimestamp(): ?int

pkg/sqs/Tests/Functional/SqsCommonUseCasesTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function testProduceAndReceiveOneMessageSentDirectlyToQueue()
102102

103103
$this->assertEquals(__METHOD__, $message->getBody());
104104
$this->assertEquals(['FooProperty' => 'FooVal'], $message->getProperties());
105-
$this->assertEquals('BarVal', $message->getHeaders()['BarHeader']);
105+
$this->assertEquals(['BarHeader' => 'BarVal'], $message->getHeaders());
106106
$this->assertNotNull($message->getMessageId());
107107
}
108108

pkg/sqs/Tests/SqsConsumerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public function testShouldReceiveMessage()
338338

339339
$this->assertInstanceOf(SqsMessage::class, $result);
340340
$this->assertEquals('The Body', $result->getBody());
341-
$this->assertEquals(['hkey' => 'hvalue', 'message_id' => 'theMessageId'], $result->getHeaders());
341+
$this->assertEquals(['hkey' => 'hvalue'], $result->getHeaders());
342342
$this->assertEquals(['key' => 'value'], $result->getProperties());
343343
$this->assertEquals([
344344
'SenderId' => 'AROAX5IAWYILCTYIS3OZ5:[email protected]',

0 commit comments

Comments
 (0)